From: David Woodhouse <dwmw2@infradead.org>
To: Vojtech Pavlik <vojtech@suse.cz>
Cc: Russell King <rmk@arm.linux.org.uk>,
linux-kernel@vger.kernel.org,
linuxconsole-dev@lists.sourceforge.net
Subject: Re: [patch] Fix suspend of the kseriod thread
Date: Wed, 31 Jul 2002 11:07:21 +0100 [thread overview]
Message-ID: <10657.1028110041@redhat.com> (raw)
In-Reply-To: <20020731115818.A26329@ucw.cz>
vojtech@suse.cz said:
> Ok. Is the use in drivers/input/serio.c buggy?
If it matters that the thread can miss wakeup events and sleep indefinitely
while there's a 'SERIO_RESCAN' event pending, then yes it looks buggy.
serio_thread() serio_rescan()
-------------- --------------
serio_handle_events();
serio->event |= SERIO_RESCAN;
wake_up(&serio_wait);
sleep_on(&serio_wait);
...sleeps...
If both serio_thread() and serio_rescan() hold the BKL you're OK. It looks
like serio_rescan() doesn't, though.
> What should be it replaced with?
In general, the response 'anything but sleep_on' is considered appropriate.
Try wait_event().
--
dwmw2
next prev parent reply other threads:[~2002-07-31 10:14 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-30 10:26 [patch] Small input fixes for 2.5.29 [1/2] Vojtech Pavlik
2002-07-30 10:29 ` [patch] Small input fixes for 2.5.29 [2/2] Vojtech Pavlik
2002-07-30 13:22 ` [patch] Input cleanups for 2.5.29 [1/2] Vojtech Pavlik
2002-07-30 13:23 ` [patch] Input cleanups for 2.5.29 [2/2] Vojtech Pavlik
2002-07-30 20:17 ` [patch] Fix suspend of the kseriod thread Vojtech Pavlik
2002-07-30 20:18 ` [patch] Remove superfluous code that snuck back in PPC merge Vojtech Pavlik
2002-07-30 21:57 ` [patch] Fix suspend of the kseriod thread Russell King
2002-07-30 22:00 ` Vojtech Pavlik
2002-07-31 9:55 ` David Woodhouse
2002-07-31 9:58 ` Vojtech Pavlik
2002-07-31 10:07 ` David Woodhouse [this message]
2002-07-31 10:10 ` Vojtech Pavlik
2002-07-31 11:44 ` sleep_on() DIE DIE DIE (was Re: [patch] Fix suspend of the kseriod thread) David Woodhouse
2002-07-30 21:09 ` [patch] Input cleanups for 2.5.29 [2/2] Greg KH
2002-07-30 21:20 ` Linus Torvalds
2002-07-30 21:35 ` Vojtech Pavlik
2002-07-30 21:46 ` Linus Torvalds
2002-07-30 22:02 ` Vojtech Pavlik
2002-07-30 21:38 ` Brad Hards
2002-07-30 21:26 ` Brad Hards
2002-07-30 21:35 ` Linus Torvalds
2002-07-30 21:42 ` Alexander Viro
2002-07-30 21:47 ` Brad Hards
2002-07-30 22:02 ` Alexander Viro
2002-07-30 22:05 ` Alexander Viro
2002-08-01 10:49 ` Pavel Machek
2002-08-01 12:17 ` Sean Neakums
2002-07-30 22:04 ` Linus Torvalds
2002-07-30 21:55 ` Ben Pfaff
2002-07-30 22:03 ` Alexander Viro
2002-07-31 13:42 ` Alan Cox
2002-07-31 12:57 ` Andreas Schwab
2002-07-31 14:01 ` extended integer types (was Re: [patch] Input cleanups for 2.5.29 [2/2]) Bill Rugolsky Jr.
2002-07-30 21:39 ` [patch] Input cleanups for 2.5.29 [2/2] Vojtech Pavlik
2002-07-30 22:46 ` Kai Henningsen
2002-07-30 21:45 ` Jeff Garzik
2002-07-30 21:59 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10657.1028110041@redhat.com \
--to=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxconsole-dev@lists.sourceforge.net \
--cc=rmk@arm.linux.org.uk \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.