Re: linux 2.4.18-5 nfs/rpc problem

[David Jeffery <david_jeffery@adaptec.com>]

On Fri, 2003-10-10 at 15:44, Trond Myklebust wrote:
> >>>>> " " == Trond Myklebust <trond.myklebust@fys.uio.no> writes:
> 
>      > There is indeed one case where this is not being done: in
>      > page_launder() you only have a lock on the page. This means
>      > that you may end up calling nfs_wait_on_request() in order to
>      > flush out a page only to discover that it called iput() from
>      > beneath you and is now waiting in clear_inode() on your page
>      > lock.
> 
> Sorry. I meant 'shrink_cache()'. page_launder() probably disappeared
> around 2.4.10 8-).
> 
> The point was that writepage() should be the only case where the above
> is a problem. I believe readpage does not suffer from the same issue
> since it can only be called while the file is still open...
> 
> Cheers,
>   Trond

Trond,

I don't see any holes in your much simpler patch.  I'm glad you spotted
a much simpler approach than mine.  I really didn't like the ugly
-EDEADLK game I was playing in my second patch. I'll post something if I
see a problem but I doubt I will. Thanks Trond.

David Jeffery






-------------------------------------------------------
This SF.net email is sponsored by: SF.net Giveback Program.
SourceForge.net hosts over 70,000 Open Source Projects.
See the people who have HELPED US provide better services:
Click here: http://sourceforge.net/supporters.php
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs