From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Herrenschmidt Subject: Re: Re: FBDEV 2.6.0-test7 updates. Date: Thu, 16 Oct 2003 10:19:12 +0200 Sender: linux-fbdev-devel-admin@lists.sourceforge.net Message-ID: <1066292352.661.114.camel@gaston> References: <20031015162056.018737f1.akpm@osdl.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.11] helo=sc8-sf-mx1.sourceforge.net) by sc8-sf-list1.sourceforge.net with esmtp (Cipher TLSv1:DES-CBC3-SHA:168) (Exim 3.31-VA-mm2 #1 (Debian)) id 1AA3Me-0000tI-00 for ; Thu, 16 Oct 2003 01:20:08 -0700 Received: from pentafluge.infradead.org ([213.86.99.235]) by sc8-sf-mx1.sourceforge.net with esmtp (TLSv1:AES256-SHA:256) (Exim 4.22) id 1AA3Mc-0006wH-Vk for linux-fbdev-devel@lists.sourceforge.net; Thu, 16 Oct 2003 01:20:07 -0700 In-Reply-To: <20031015162056.018737f1.akpm@osdl.org> Errors-To: linux-fbdev-devel-admin@lists.sourceforge.net List-Help: List-Post: List-Subscribe: , List-Id: List-Unsubscribe: , List-Archive: Content-Type: text/plain; charset="us-ascii" To: Andrew Morton Cc: James Simmons , Linux Fbdev development list , Linux Kernel list On Thu, 2003-10-16 at 01:20, Andrew Morton wrote: > James Simmons wrote: > > > > Here is the latest fbdev patches. > > This one comes up again and again. What should we do with it? The fix is wrong for accelerated displays. rinfo->pitch should be initialized previously, but then, I'm not sure what version of radeonfb James actually has in his tree. I'm mostly rewriting it now, though my "new" version hasn't been submited yet, it's definitely not ready. I could eventually submit an updated "old" version though... Ben. ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. SourceForge.net hosts over 70,000 Open Source Projects. See the people who have HELPED US provide better services: Click here: http://sourceforge.net/supporters.php From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262765AbTJPIUI (ORCPT ); Thu, 16 Oct 2003 04:20:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262767AbTJPIUI (ORCPT ); Thu, 16 Oct 2003 04:20:08 -0400 Received: from pentafluge.infradead.org ([213.86.99.235]:61068 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S262765AbTJPIUF (ORCPT ); Thu, 16 Oct 2003 04:20:05 -0400 Subject: Re: [Linux-fbdev-devel] Re: FBDEV 2.6.0-test7 updates. From: Benjamin Herrenschmidt To: Andrew Morton Cc: James Simmons , Linux Fbdev development list , Linux Kernel list In-Reply-To: <20031015162056.018737f1.akpm@osdl.org> References: <20031015162056.018737f1.akpm@osdl.org> Content-Type: text/plain Message-Id: <1066292352.661.114.camel@gaston> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 Date: Thu, 16 Oct 2003 10:19:12 +0200 Content-Transfer-Encoding: 7bit X-SA-Exim-Mail-From: benh@kernel.crashing.org X-SA-Exim-Scanned: No; SAEximRunCond expanded to false X-Pentafluge-Mail-From: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2003-10-16 at 01:20, Andrew Morton wrote: > James Simmons wrote: > > > > Here is the latest fbdev patches. > > This one comes up again and again. What should we do with it? The fix is wrong for accelerated displays. rinfo->pitch should be initialized previously, but then, I'm not sure what version of radeonfb James actually has in his tree. I'm mostly rewriting it now, though my "new" version hasn't been submited yet, it's definitely not ready. I could eventually submit an updated "old" version though... Ben.