From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E39F8C433E2 for ; Wed, 2 Sep 2020 16:48:11 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF73D20767 for ; Wed, 2 Sep 2020 16:48:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rddlBmiU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF73D20767 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siol.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Nl3uiEn6ajUuyjqtNSBG3QtqIyRqdkdGYI/tjJunlIg=; b=rddlBmiUbJOD1aIPnyL81ugRf EohD71pbpIfcSwWeaYYvLxf7VWb3gf09BExlzwN9qUu1580BUKQ/FSTg21XjlFDkUP8BHhnZGufDN lBQQ18ElF9ZZWxs/QyCV4/TdCHZhmmiq7/0r3wMDHAhzWtMRUCQp/CSjzP5VzjlPyI+ze8KAaPBLe 9y5iG9vb7r85q0HuZjYNTHtHorCFtm96yry20Nuf6jjqB+PES44KTv6KbthWDpGOD9h22xSe8gBru IewnPrJH9XaCS3jDo1qlG+IcdAfDs6nomoHPe5BxZNvkU7VoijRLHKBQhvyAXAzE5VupGuCa4ySpf 2sGSsJ6EQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDVuL-0000Cj-Kd; Wed, 02 Sep 2020 16:46:49 +0000 Received: from mailoutvs31.siol.net ([185.57.226.222] helo=mail.siol.net) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDVuH-0000Bu-RD for linux-arm-kernel@lists.infradead.org; Wed, 02 Sep 2020 16:46:47 +0000 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 5D25E52676B; Wed, 2 Sep 2020 18:46:43 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta11.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta11.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ORtNQRatnqJ9; Wed, 2 Sep 2020 18:46:43 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id E90D752676F; Wed, 2 Sep 2020 18:46:42 +0200 (CEST) Received: from kista.localnet (cpe1-5-97.cable.triera.net [213.161.5.97]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id DB01552676B; Wed, 2 Sep 2020 18:46:40 +0200 (CEST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Roman Stratiienko Subject: Re: [PATCH] drm/sun4i: Fix DE2 YVU handling Date: Wed, 02 Sep 2020 18:51:15 +0200 Message-ID: <10671571.W45mMbEh4O@kista> In-Reply-To: References: <20200901220305.6809-1-jernej.skrabec@siol.net> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200902_124646_046362_472669C7 X-CRM114-Status: GOOD ( 20.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: irlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, wens@csie.org, mripard@kernel.org, daniel@ffwll.ch, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RG5lIHNyZWRhLCAwMi4gc2VwdGVtYmVyIDIwMjAgb2IgMDk6MDE6MTcgQ0VTVCBqZSBSb21hbiBT dHJhdGlpZW5rbyAKbmFwaXNhbChhKToKPiDRgdGALCAyINGB0LXQvdGCLiAyMDIwINCzLiDQsiAw MDo1OCwgSmVybmVqIFNrcmFiZWMgPGplcm5lai5za3JhYmVjQHNpb2wubmV0PjoKPiA+IEZ1bmN0 aW9uIHN1bjhpX3ZpX2xheWVyX2dldF9jc2NfbW9kZSgpIGlzIHN1cHBvc2VkIHRvIHJldHVybiBD U0MgbW9kZQo+ID4gYnV0IGR1ZSB0byBpbnByb3BlciByZXR1cm4gdHlwZSAoYm9vbCBpbnN0ZWFk IG9mIHUzMikgaXQgcmV0dXJucyBqdXN0IDAKPiA+IG9yIDEuIENvbG9ycyBhcmUgd3JvbmcgZm9y IFlWVSBmb3JtYXRzIGJlY2F1c2Ugb2YgdGhhdC4KPiA+IAo+ID4gRml4ZXM6IGRhYWIzZDBlOGUy YiAoImRybS9zdW40aTogZGUyOiBjc2NfbW9kZSBpbiBkZTIgZm9ybWF0IHN0cnVjdCBpcwo+ID4g bW9zdGx5IHJlZHVuZGFudCIpIFJlcG9ydGVkLWJ5OiBSb21hbiBTdHJhdGlpZW5rbwo+ID4gPHIu c3RyYXRpaWVua29AZ21haWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogSmVybmVqIFNrcmFiZWMg PGplcm5lai5za3JhYmVjQHNpb2wubmV0Pgo+ID4gLS0tCj4gPiAKPiA+ICBkcml2ZXJzL2dwdS9k cm0vc3VuNGkvc3VuOGlfdmlfbGF5ZXIuYyB8IDIgKy0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMSBp bnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9zdW40aS9zdW44aV92aV9sYXllci5jCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9zdW40 aS9zdW44aV92aV9sYXllci5jIGluZGV4IDIyYzhjNTM3NWQwZC4uYzAxNDdhZjZhODQwCj4gPiAx MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9zdW40aS9zdW44aV92aV9sYXllci5jCj4g PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuOGlfdmlfbGF5ZXIuYwo+ID4gQEAgLTIx MSw3ICsyMTEsNyBAQCBzdGF0aWMgaW50IHN1bjhpX3ZpX2xheWVyX3VwZGF0ZV9jb29yZChzdHJ1 Y3QKPiA+IHN1bjhpX21peGVyICptaXhlciwgaW50IGNoYW5uZWwsPiAKPiA+ICAgICAgICAgcmV0 dXJuIDA7Cj4gPiAgCj4gPiAgfQo+ID4gCj4gPiAtc3RhdGljIGJvb2wgc3VuOGlfdmlfbGF5ZXJf Z2V0X2NzY19tb2RlKGNvbnN0IHN0cnVjdCBkcm1fZm9ybWF0X2luZm8KPiA+ICpmb3JtYXQpICtz dGF0aWMgdTMyIHN1bjhpX3ZpX2xheWVyX2dldF9jc2NfbW9kZShjb25zdCBzdHJ1Y3QKPiA+IGRy bV9mb3JtYXRfaW5mbyAqZm9ybWF0KT4gCj4gPiAgewo+ID4gIAo+ID4gICAgICAgICBpZiAoIWZv cm1hdC0+aXNfeXV2KQo+ID4gICAgICAgICAKPiA+ICAgICAgICAgICAgICAgICByZXR1cm4gU1VO OElfQ1NDX01PREVfT0ZGOwo+ID4gCj4gPiAtLQo+ID4gMi4yOC4wCj4gCj4gSGkgSmVybmVqLAo+ IAo+IFRoYW5rIHlvdSBmb3IgdGhlIGZpeC4KPiBJIGNhbiBjb25maXJtIHRoaXMgcGF0Y2ggZml4 ZXMgdGhlIGlzc3VlIHdpdGggd3JvbmcgY29sb3JzLgoKVGhhbmtzISBDYW4gSSBhc3N1bWUgdGhh dCB0aGlzIG1lYW5zIHlvdXIgVGVzdGVkLWJ5IHRhZyBjYW4gYmUgYWRkZWQ/Cgo+IAo+IExldCBt ZSBzaGFyZSBteSB0aG91Z2h0czoKPiBJJ3ZlIGxvb2tlZCBpbnRvIGNzYyBjb2RlLCBhbmQgaXQg c2VlbXMgdG8gbWUgcmVvcmRlcmluZyBVLCBWIG9mZnNldHMKPiBzaG91bGQgYmUgYSBtdWNoIHNp bXBsZXIgc29sdXRpb24gdGhhbiBhcHBseWluZwo+IGNvbG9yIHRyYW5zZm9ybWF0aW9uIG1hdHJp Y2VzLkl0IHNob3VsZCBhbHNvIHNpbXBsaWZ5IGFkZGluZyBtb3JlCj4gY29sb3IgZW5jb2Rpbmdz IGluIHRoZSBmdXR1cmUuCgpTd2l0Y2hpbmcgb2Zmc2V0cyBhc3N1bWVzIHRoYXQgeW91IGhhdmUg c2VwYXJhdGUgcGxhbmVzIGZvciBVIGFuZCBWIHdoaWNoIG1heSAKbm90IGJlIHRydWUgaW4gdGhl IGZ1dHVyZS4gSSBhZ3JlZSB0aGF0IENTQyBtYXRyaWNlcyBhcmUgbmVlZGxlc3NseSBkdXBsaWNh dGVkIApmb3IgaGFuZGxpbmcgVS9WIHN3aXRjaC4gSSBoYXZlIGEgcGF0Y2ggd2hpY2ggcmVvcmdh bml6ZSBtYXRyaXggb24gdGhlIGZseSB3aGVuIApjb2VmZmljaWVudHMgYXJlIHdyaXR0ZW4gaW4g cmVnaXN0ZXJzIGJ1dCBzaW5jZSBpdCdzIGEgcGFydCBvZiBhIGJpZ2dlciwgCnVuZmluaXNoZWQg c2VyaWVzLCBJIGRpZG4ndCBzZW50IGl0IG91dCB5ZXQuIE9ubHkgZGlmZmVyZW5jZSBpbiBZVVYg YW5kIFlWVSBDU0MgCm1hdHJpY2VzIGFyZSBzd2l0Y2hlZCAybmQgYW5kIDNyZCBjb2x1bW4uCgpC ZXN0IHJlZ2FyZHMsCkplcm5lagoKPiAKPiBSZWdhcmRzLAo+IFJvbWFuCgoKCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24A5EC433E7 for ; Thu, 3 Sep 2020 08:50:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD3B92065F for ; Thu, 3 Sep 2020 08:50:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD3B92065F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siol.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C46CD6E4DD; Thu, 3 Sep 2020 08:50:08 +0000 (UTC) Received: from mail.siol.net (mailoutvs3.siol.net [185.57.226.194]) by gabe.freedesktop.org (Postfix) with ESMTPS id A5B646E936 for ; Wed, 2 Sep 2020 16:46:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 5D25E52676B; Wed, 2 Sep 2020 18:46:43 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta11.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta11.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ORtNQRatnqJ9; Wed, 2 Sep 2020 18:46:43 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id E90D752676F; Wed, 2 Sep 2020 18:46:42 +0200 (CEST) Received: from kista.localnet (cpe1-5-97.cable.triera.net [213.161.5.97]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id DB01552676B; Wed, 2 Sep 2020 18:46:40 +0200 (CEST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Roman Stratiienko Subject: Re: [PATCH] drm/sun4i: Fix DE2 YVU handling Date: Wed, 02 Sep 2020 18:51:15 +0200 Message-ID: <10671571.W45mMbEh4O@kista> In-Reply-To: References: <20200901220305.6809-1-jernej.skrabec@siol.net> MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 03 Sep 2020 08:50:07 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: irlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, wens@csie.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" RG5lIHNyZWRhLCAwMi4gc2VwdGVtYmVyIDIwMjAgb2IgMDk6MDE6MTcgQ0VTVCBqZSBSb21hbiBT dHJhdGlpZW5rbyAKbmFwaXNhbChhKToKPiDRgdGALCAyINGB0LXQvdGCLiAyMDIwINCzLiDQsiAw MDo1OCwgSmVybmVqIFNrcmFiZWMgPGplcm5lai5za3JhYmVjQHNpb2wubmV0PjoKPiA+IEZ1bmN0 aW9uIHN1bjhpX3ZpX2xheWVyX2dldF9jc2NfbW9kZSgpIGlzIHN1cHBvc2VkIHRvIHJldHVybiBD U0MgbW9kZQo+ID4gYnV0IGR1ZSB0byBpbnByb3BlciByZXR1cm4gdHlwZSAoYm9vbCBpbnN0ZWFk IG9mIHUzMikgaXQgcmV0dXJucyBqdXN0IDAKPiA+IG9yIDEuIENvbG9ycyBhcmUgd3JvbmcgZm9y IFlWVSBmb3JtYXRzIGJlY2F1c2Ugb2YgdGhhdC4KPiA+IAo+ID4gRml4ZXM6IGRhYWIzZDBlOGUy YiAoImRybS9zdW40aTogZGUyOiBjc2NfbW9kZSBpbiBkZTIgZm9ybWF0IHN0cnVjdCBpcwo+ID4g bW9zdGx5IHJlZHVuZGFudCIpIFJlcG9ydGVkLWJ5OiBSb21hbiBTdHJhdGlpZW5rbwo+ID4gPHIu c3RyYXRpaWVua29AZ21haWwuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogSmVybmVqIFNrcmFiZWMg PGplcm5lai5za3JhYmVjQHNpb2wubmV0Pgo+ID4gLS0tCj4gPiAKPiA+ICBkcml2ZXJzL2dwdS9k cm0vc3VuNGkvc3VuOGlfdmlfbGF5ZXIuYyB8IDIgKy0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMSBp bnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9zdW40aS9zdW44aV92aV9sYXllci5jCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9zdW40 aS9zdW44aV92aV9sYXllci5jIGluZGV4IDIyYzhjNTM3NWQwZC4uYzAxNDdhZjZhODQwCj4gPiAx MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9zdW40aS9zdW44aV92aV9sYXllci5jCj4g PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuOGlfdmlfbGF5ZXIuYwo+ID4gQEAgLTIx MSw3ICsyMTEsNyBAQCBzdGF0aWMgaW50IHN1bjhpX3ZpX2xheWVyX3VwZGF0ZV9jb29yZChzdHJ1 Y3QKPiA+IHN1bjhpX21peGVyICptaXhlciwgaW50IGNoYW5uZWwsPiAKPiA+ICAgICAgICAgcmV0 dXJuIDA7Cj4gPiAgCj4gPiAgfQo+ID4gCj4gPiAtc3RhdGljIGJvb2wgc3VuOGlfdmlfbGF5ZXJf Z2V0X2NzY19tb2RlKGNvbnN0IHN0cnVjdCBkcm1fZm9ybWF0X2luZm8KPiA+ICpmb3JtYXQpICtz dGF0aWMgdTMyIHN1bjhpX3ZpX2xheWVyX2dldF9jc2NfbW9kZShjb25zdCBzdHJ1Y3QKPiA+IGRy bV9mb3JtYXRfaW5mbyAqZm9ybWF0KT4gCj4gPiAgewo+ID4gIAo+ID4gICAgICAgICBpZiAoIWZv cm1hdC0+aXNfeXV2KQo+ID4gICAgICAgICAKPiA+ICAgICAgICAgICAgICAgICByZXR1cm4gU1VO OElfQ1NDX01PREVfT0ZGOwo+ID4gCj4gPiAtLQo+ID4gMi4yOC4wCj4gCj4gSGkgSmVybmVqLAo+ IAo+IFRoYW5rIHlvdSBmb3IgdGhlIGZpeC4KPiBJIGNhbiBjb25maXJtIHRoaXMgcGF0Y2ggZml4 ZXMgdGhlIGlzc3VlIHdpdGggd3JvbmcgY29sb3JzLgoKVGhhbmtzISBDYW4gSSBhc3N1bWUgdGhh dCB0aGlzIG1lYW5zIHlvdXIgVGVzdGVkLWJ5IHRhZyBjYW4gYmUgYWRkZWQ/Cgo+IAo+IExldCBt ZSBzaGFyZSBteSB0aG91Z2h0czoKPiBJJ3ZlIGxvb2tlZCBpbnRvIGNzYyBjb2RlLCBhbmQgaXQg c2VlbXMgdG8gbWUgcmVvcmRlcmluZyBVLCBWIG9mZnNldHMKPiBzaG91bGQgYmUgYSBtdWNoIHNp bXBsZXIgc29sdXRpb24gdGhhbiBhcHBseWluZwo+IGNvbG9yIHRyYW5zZm9ybWF0aW9uIG1hdHJp Y2VzLkl0IHNob3VsZCBhbHNvIHNpbXBsaWZ5IGFkZGluZyBtb3JlCj4gY29sb3IgZW5jb2Rpbmdz IGluIHRoZSBmdXR1cmUuCgpTd2l0Y2hpbmcgb2Zmc2V0cyBhc3N1bWVzIHRoYXQgeW91IGhhdmUg c2VwYXJhdGUgcGxhbmVzIGZvciBVIGFuZCBWIHdoaWNoIG1heSAKbm90IGJlIHRydWUgaW4gdGhl IGZ1dHVyZS4gSSBhZ3JlZSB0aGF0IENTQyBtYXRyaWNlcyBhcmUgbmVlZGxlc3NseSBkdXBsaWNh dGVkIApmb3IgaGFuZGxpbmcgVS9WIHN3aXRjaC4gSSBoYXZlIGEgcGF0Y2ggd2hpY2ggcmVvcmdh bml6ZSBtYXRyaXggb24gdGhlIGZseSB3aGVuIApjb2VmZmljaWVudHMgYXJlIHdyaXR0ZW4gaW4g cmVnaXN0ZXJzIGJ1dCBzaW5jZSBpdCdzIGEgcGFydCBvZiBhIGJpZ2dlciwgCnVuZmluaXNoZWQg c2VyaWVzLCBJIGRpZG4ndCBzZW50IGl0IG91dCB5ZXQuIE9ubHkgZGlmZmVyZW5jZSBpbiBZVVYg YW5kIFlWVSBDU0MgCm1hdHJpY2VzIGFyZSBzd2l0Y2hlZCAybmQgYW5kIDNyZCBjb2x1bW4uCgpC ZXN0IHJlZ2FyZHMsCkplcm5lagoKPiAKPiBSZWdhcmRzLAo+IFJvbWFuCgoKCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A087C433E7 for ; Wed, 2 Sep 2020 16:46:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A64C20767 for ; Wed, 2 Sep 2020 16:46:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728197AbgIBQqu convert rfc822-to-8bit (ORCPT ); Wed, 2 Sep 2020 12:46:50 -0400 Received: from mailoutvs19.siol.net ([185.57.226.210]:44758 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727776AbgIBQqq (ORCPT ); Wed, 2 Sep 2020 12:46:46 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 5D25E52676B; Wed, 2 Sep 2020 18:46:43 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta11.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta11.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ORtNQRatnqJ9; Wed, 2 Sep 2020 18:46:43 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id E90D752676F; Wed, 2 Sep 2020 18:46:42 +0200 (CEST) Received: from kista.localnet (cpe1-5-97.cable.triera.net [213.161.5.97]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id DB01552676B; Wed, 2 Sep 2020 18:46:40 +0200 (CEST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Roman Stratiienko Cc: mripard@kernel.org, wens@csie.org, irlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/sun4i: Fix DE2 YVU handling Date: Wed, 02 Sep 2020 18:51:15 +0200 Message-ID: <10671571.W45mMbEh4O@kista> In-Reply-To: References: <20200901220305.6809-1-jernej.skrabec@siol.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dne sreda, 02. september 2020 ob 09:01:17 CEST je Roman Stratiienko napisal(a): > ср, 2 сент. 2020 г. в 00:58, Jernej Skrabec : > > Function sun8i_vi_layer_get_csc_mode() is supposed to return CSC mode > > but due to inproper return type (bool instead of u32) it returns just 0 > > or 1. Colors are wrong for YVU formats because of that. > > > > Fixes: daab3d0e8e2b ("drm/sun4i: de2: csc_mode in de2 format struct is > > mostly redundant") Reported-by: Roman Stratiienko > > > > Signed-off-by: Jernej Skrabec > > --- > > > > drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > > b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c index 22c8c5375d0d..c0147af6a840 > > 100644 > > --- a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > > +++ b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c > > @@ -211,7 +211,7 @@ static int sun8i_vi_layer_update_coord(struct > > sun8i_mixer *mixer, int channel,> > > return 0; > > > > } > > > > -static bool sun8i_vi_layer_get_csc_mode(const struct drm_format_info > > *format) +static u32 sun8i_vi_layer_get_csc_mode(const struct > > drm_format_info *format)> > > { > > > > if (!format->is_yuv) > > > > return SUN8I_CSC_MODE_OFF; > > > > -- > > 2.28.0 > > Hi Jernej, > > Thank you for the fix. > I can confirm this patch fixes the issue with wrong colors. Thanks! Can I assume that this means your Tested-by tag can be added? > > Let me share my thoughts: > I've looked into csc code, and it seems to me reordering U, V offsets > should be a much simpler solution than applying > color transformation matrices.It should also simplify adding more > color encodings in the future. Switching offsets assumes that you have separate planes for U and V which may not be true in the future. I agree that CSC matrices are needlessly duplicated for handling U/V switch. I have a patch which reorganize matrix on the fly when coefficients are written in registers but since it's a part of a bigger, unfinished series, I didn't sent it out yet. Only difference in YUV and YVU CSC matrices are switched 2nd and 3rd column. Best regards, Jernej > > Regards, > Roman