Re: [PATCH] sr cd->device->writeable without purpose

[Pat LaVarre <p.lavarre@ieee.org>]

Kindly offline I hear:

> I think the sr cd->device->writeable bit becomes vestigial - has no
> remaining purpose - once we branch on CDC_MMC_WR instead of
> cd->device->writeable to decide to pass thru or reject writes.

That might or might not be true.  However,

> This patch differs from that simpler CDC_MMC_WR patch by updating sr
> cd->device->writeable bit whenever cdrom corrects the sr guess of
> CDC_MMC_WR via op x46 GPCMD_GET_CONFIGURATION.

Ouch, rather silly of me.  In that patch, me the newbie, I foolishly:

a) grew cdrom_device_ops to call back into sr ...
b) just before cdrom_get_configuration returns to cdrom_get_cdc, ...
c) just before cdrom_get_cdc returns to register_cdrom, ...
d) just before register_cdrom returns to sr.sr_probe.

That is, I can run the same sr code at almost precisely the same time if
only I place that code immediately after the call to register_cdrom in
sr.sr_probe.

D'oh.

Pat LaVarre