From: Thomas Monjalon <thomas@monjalon.net>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, stable@dpdk.org, yong.liu@intel.com,
david.marchand@redhat.com,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] config: enable packet prefetching with Meson
Date: Sat, 14 Nov 2020 10:00:33 +0100 [thread overview]
Message-ID: <10682579.uibSL3b33d@thomas> (raw)
In-Reply-To: <11842873.9WOr1mrSjh@thomas>
14/11/2020 09:51, Thomas Monjalon:
> 13/11/2020 16:05, Bruce Richardson:
> > On Fri, Nov 13, 2020 at 03:52:12PM +0100, Maxime Coquelin wrote:
> > > With Make build system, RTE_PMD_PACKET_PREFETCH was enabled
> > > by default. It got lost when transitioning to Meson build
> > > system.
> > >
> > > In order to avoid performance changes, this patch enables
> > > packet prefetching in rte_config.h.
> > >
> > > Reported-by: Marvin Liu <yong.liu@intel.com>
> > > Suggested-by: David Marchand <david.marchand@redhat.com>
> > > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
[...]
>
> Applied with backport info, thanks.
Note that it is added back for "compatibility",
but I am still in favour of dropping this config option,
replaced by arch decision if any:
http://inbox.dpdk.org/dev/3677226.MZCibFMyqQ@thomas/
The decision of such optimization should be done in DPDK project,
not in the hand of the packager.
next prev parent reply other threads:[~2020-11-14 9:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 14:52 [dpdk-dev] [PATCH] config: enable packet prefetching with Meson Maxime Coquelin
2020-11-13 15:05 ` Bruce Richardson
2020-11-14 8:51 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2020-11-14 9:00 ` Thomas Monjalon [this message]
2020-11-14 10:54 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10682579.uibSL3b33d@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.