All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: dhowells@redhat.com, "David S. Miller" <davem@davemloft.net>,
	linux-crypto@vger.kernel.org
Subject: Incorrect use of CRYPTO_ALG_ASYNC in crypto_alloc_sync_skcipher()?
Date: Tue, 09 Apr 2024 10:51:30 +0100	[thread overview]
Message-ID: <1068289.1712656290@warthog.procyon.org.uk> (raw)

Hi Herbert,

Is the following code in crypto_alloc_sync_skcipher() wrong:

	/* Only sync algorithms allowed. */
	mask |= CRYPTO_ALG_ASYNC | CRYPTO_ALG_SKCIPHER_REQSIZE_LARGE;

in its specification of CRYPTO_ALG_ASYNC?  Given what the docs say:

    The mask flag restricts the type of cipher. The only allowed flag is
    CRYPTO_ALG_ASYNC to restrict the cipher lookup function to
    asynchronous ciphers. Usually, a caller provides a 0 for the mask flag.
    ^^^^^^^^^^^^

or are the docs wrong?

David


             reply	other threads:[~2024-04-09  9:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-09  9:51 David Howells [this message]
2024-04-09  9:56 ` Incorrect use of CRYPTO_ALG_ASYNC in crypto_alloc_sync_skcipher()? Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1068289.1712656290@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.