From: Thomas Monjalon <thomas@monjalon.net>
To: Matan Azrad <matan@mellanox.com>
Cc: Shahaf Shuler <shahafs@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx: replace hardcoded value with macro
Date: Mon, 10 Feb 2020 10:52:54 +0100 [thread overview]
Message-ID: <10685611.F0gNSz5aLb@xps> (raw)
In-Reply-To: <7829300.5OynTdThKG@xps>
10/02/2020 09:52, Thomas Monjalon:
> 10/02/2020 07:32, Matan Azrad:
> > From: Thomas Monjalon
> >
> > > Replace checking against 65535 limit,
> > > with a simpler form using RTE_MIN and UINT16_MAX macros.
> > >
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > ---
> >
> > No more misusing of *_MAX \ RTE_MIN\RTE_MAX in the mlx PMDs?
>
> Sorry I don't understand your question.
If you are asking if there are more hardcoded constants,
the answer is yes but they are masks.
I think the masks can remain hardcoded.
next prev parent reply other threads:[~2020-02-10 9:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-09 21:17 [dpdk-dev] [PATCH] net/mlx: replace hardcoded value with macro Thomas Monjalon
2020-02-10 6:32 ` Matan Azrad
2020-02-10 8:52 ` Thomas Monjalon
2020-02-10 9:52 ` Thomas Monjalon [this message]
2020-02-10 9:57 ` Matan Azrad
2020-02-11 8:29 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10685611.F0gNSz5aLb@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.