Re: [PATCH 1/3] hwsim: remove 'optimization' sending to only known MACs

[James Prestwood <prestwoj@gmail.com>]

Hi Denis,

On 6/28/23 9:25 AM, Denis Kenzior wrote:
> Hi James,
> 
>>>> Unfortunately once you move the radio into another namespace you 
>>>> lose any events associated with that radio, due to the PID of hwsim 
>>>> being associated with a distinct namespace (I think). So 
>>>> ADD/DEL_MAC_ADDR won't help here.
>>>
>>> Which events though?  You should always be getting HWSIM_CMD_ events 
>>> for _all_ radios since only a single hwsim instance is registered, 
>>> no? Aren't these all you need for the purposes of sending packets to 
>>> the right radio?
>>
>> ADD/DEL_MAC_ADDR, which don't come once the radio is moved to another 
>> namespace (as far as I can tell with testing).
>>
>> I think it comes down to port ID:
>>
>> u32 _portid = READ_ONCE(data->wmediumd);
>> ...
>> hwsim_unicast_netgroup(data, skb, _portid);
> 
> Then this may be a conversation you have to start on linux-wireless.  I 
> would have thought that there should only be a single wmediumd instance 
> on a system regardless of namespaces, but maybe I'm wrong here.

Yeah, I'll do that as well. This would simplify things if the namespaces 
didn't come into play.

Nevertheless, was the distributed hwsim concept something you'd be 
interested in accepting upstream? Like I said, I'm already doing it and 
I'm happy to re-use hwsim and extend to support this external socket 
concept.
> Regards,
> -Denis