Re: [dpdk-dev] [PATCH v3] build: check functionality rather than binutils version

[Thomas Monjalon <thomas@monjalon.net>]

04/07/2020 13:48, Bruce Richardson:
> Rather than checking the binutils version number, which can lead to
> unnecessary disabling of AVX512 if fixes have been backported to distro
> versions, we can instead check the output of "as" from binutils to see if
> it is correct.
> 
> The check in the script uses the minimal assembly reproduction code posted
> to the public bug tracker for gcc/binutils for those issues [1]. If the
> binutils bug is present, the instruction parameters - specifically the
> displacement parameter - will be different in the disassembled output
> compared to the input. Therefore the check involves assembling a single
> instruction and disassembling it again, checking that the two match.
> 
> [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90028
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Tested-by: Harry van Haaren <harry.van.haaren@intel.com>
> 
> ---
> V3:
> - Use mktemp to create a temporary file rather than place object file in
>   build folder. Use trap to ensure temp file deletion on exit.
> 
> V2:
> - Renamed "as_ok" variable to "binutils_ok" for readability
> - Removed one test case from the script because even though two DPDK bugs
>   were filed, the one binutils bug is the root cause, and a single commit
>   fixes them both
> - Changed message() to warning() in the printout

Applied, thanks