From: NeilBrown <neilb@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 003 of 4] md: Make sure the events count in an md array never returns to zero.
Date: Tue, 23 Jan 2007 11:26:56 +1100 [thread overview]
Message-ID: <1070123002656.29477@suse.de> (raw)
In-Reply-To: 20070123112437.29357.patches@notabene
Now that we sometimes step the array events count backwards
(when transitioning dirty->clean where nothing else interesting
has happened - so that we don't need to write to spares all the time),
it is possible for the event count to return to zero, which is
potentially confusing and triggers and MD_BUG.
We could possibly remove the MD_BUG, but is just as easy, and
probably safer, to make sure we never return to zero.
Signed-off-by: Neil Brown <neilb@suse.de>
### Diffstat output
./drivers/md/md.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff .prev/drivers/md/md.c ./drivers/md/md.c
--- .prev/drivers/md/md.c 2007-01-23 11:13:44.000000000 +1100
+++ ./drivers/md/md.c 2007-01-23 11:23:58.000000000 +1100
@@ -1633,7 +1633,8 @@ repeat:
* and 'events' is odd, we can roll back to the previous clean state */
if (nospares
&& (mddev->in_sync && mddev->recovery_cp == MaxSector)
- && (mddev->events & 1))
+ && (mddev->events & 1)
+ && mddev->events != 1)
mddev->events--;
else {
/* otherwise we have to go forward and ... */
next prev parent reply other threads:[~2007-01-23 0:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-23 0:26 [PATCH 000 of 4] md: Introduction - Assorted bugfixes NeilBrown
2007-01-23 0:26 ` [PATCH 001 of 4] md: Update email address and status for MD in MAINTAINERS NeilBrown
2007-01-23 0:26 ` [PATCH 002 of 4] md: Make 'repair' actually work for raid1 NeilBrown
2007-01-24 6:57 ` Andrew Morton
2007-01-24 7:27 ` Neil Brown
2007-01-23 0:26 ` NeilBrown [this message]
2007-01-23 0:27 ` [PATCH 004 of 4] md: Avoid reading past the end of a bitmap file NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1070123002656.29477@suse.de \
--to=neilb@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.