From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 4/6] omap3isp: Disable streaming at driver unbind time
Date: Tue, 28 Feb 2017 16:53:11 +0200 [thread overview]
Message-ID: <10713629.uzrjKBVcAn@avalon> (raw)
In-Reply-To: <a9989567-8792-480d-88e0-73ddecf0a742@linux.intel.com>
Hi Sakari,
On Tuesday 28 Feb 2017 16:00:01 Sakari Ailus wrote:
> > On Monday 20 Feb 2017 17:22:20 Sakari Ailus wrote:
> >> Once the driver is unbound accessing the hardware is not allowed anymore.
> >> Due to this, disable streaming when the device driver is unbound. The
> >> states of the associated objects related to Media controller and
> >> videobuf2 frameworks are updated as well, just like if the application
> >> disabled streaming explicitly.
> >>
> >> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> >
> > This looks mostly good to me, although I'm a bit concerned about race
> > conditions related to buffer handling. I don't think this patch introduces
> > any new one though, so
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > We'll have to go through buffer management at some point in the near
> > future, including from a V4L2 API point of view I think.
>
> Thanks for the review!
>
> Are you happy with me sending a pull request on the set, or would you
> prefer to pick the omap3isp patches? In the latter case I'll send a fix
> for the issue in the first patch.
Feel free to send a pull request, I don't have anything conflicting queued for
v4.12.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-02-28 14:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 15:22 [PATCH 0/6] Media controller and omap3isp cleanups Sakari Ailus
2017-02-20 15:22 ` [PATCH 1/6] omap3isp: Don't rely on devm for memory resource management Sakari Ailus
2017-02-28 13:12 ` Laurent Pinchart
2017-02-28 13:21 ` Sakari Ailus
2017-02-20 15:22 ` [PATCH 2/6] omap3isp: Call video_unregister_device() unconditionally Sakari Ailus
2017-02-28 13:42 ` Laurent Pinchart
2017-02-20 15:22 ` [PATCH 3/6] omap3isp: Remove misleading comment Sakari Ailus
2017-02-28 13:42 ` Laurent Pinchart
2017-02-20 15:22 ` [PATCH 4/6] omap3isp: Disable streaming at driver unbind time Sakari Ailus
2017-02-28 13:51 ` Laurent Pinchart
2017-02-28 14:00 ` Sakari Ailus
2017-02-28 14:53 ` Laurent Pinchart [this message]
2017-02-24 13:13 ` Sakari Ailus
2017-02-20 15:22 ` [PATCH 5/6] media: Remove useless curly braces and parentheses Sakari Ailus
2017-02-28 13:42 ` Laurent Pinchart
2017-02-20 15:22 ` [PATCH 6/6] media: devnode: Rename mdev argument as devnode Sakari Ailus
2017-02-28 13:42 ` Laurent Pinchart
2017-02-20 20:37 ` [PATCH 0/6] Media controller and omap3isp cleanups Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10713629.uzrjKBVcAn@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.