All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@steeleye.com>
To: Mike Christie <mikenc@us.ibm.com>
Cc: James Daniel <jdaniel@dakotacom.net>,
	SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: Initio 9100u -- Mike Christie's 2.6.0-test11 Patch -- Kernel Errors
Date: 21 Dec 2003 09:46:38 -0600	[thread overview]
Message-ID: <1072021603.1952.10.camel@mulgrave> (raw)
In-Reply-To: <Pine.LNX.4.44.0312190311160.27880-200000@dyn319634.beaverton.ibm.com>

On Fri, 2003-12-19 at 05:15, Mike Christie wrote:
> Here is another try. It should compile against 2.6.0-test11/2.6.0.

That's great thanks.  I've put it in the scsi tree.

I did notice in the diffs between this one and the previous patch things
like:


-			pSG->SG_Ptr = cpu_to_le32((u32)sg_dma_address(pSrbSG));
-			TotalLen += pSG->SG_Len = cpu_to_le32((u32)sg_dma_len(pSrbSG));
+			pSG->SG_Ptr = (u32)sg_dma_address(pSrbSG);
+			TotalLen += pSG->SG_Len = (u32)sg_dma_len(pSrbSG);

Which is obviously incorrect, since sg_dma_address() does return the
address in CPU endianness (and the device SG list needs to be in PCI
endiannes), but I think, since it was hard enough to find anyone with
one of these things, that the chances of finding one on a non-x86 box
are zero.

James




  parent reply	other threads:[~2003-12-21 15:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-17  9:05 Initio 9100u -- Mike Christie's 2.6.0-test11 Patch -- Kernel Errors James Daniel
2003-12-17 14:24 ` James Bottomley
2003-12-18  7:00   ` Mike Christie
2003-12-18  9:45     ` Mike Christie
2003-12-19  2:14       ` James Daniel
2003-12-19  9:26         ` Mike Christie
2003-12-19 11:15           ` Mike Christie
2003-12-21 11:09             ` [FIXED] Initio 9100u -- It lives James Daniel
2003-12-21 15:46             ` James Bottomley [this message]
2003-12-22 23:42               ` Initio 9100u -- Mike Christie's 2.6.0-test11 Patch -- Kernel Errors Mike Christie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1072021603.1952.10.camel@mulgrave \
    --to=james.bottomley@steeleye.com \
    --cc=jdaniel@dakotacom.net \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mikenc@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.