All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Nicolas Saenz Julienne <nsaenz@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Maxime Ripard <maxime@cerno.tech>,
	devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/9] ARM: dts: bcm2711: fix emmc2bus node name
Date: Mon, 02 Aug 2021 11:25:24 +0100	[thread overview]
Message-ID: <1072417634cf20c7dc46e545e9fcd242@kernel.org> (raw)
In-Reply-To: <1627820932-7247-2-git-send-email-stefan.wahren@i2se.com>

On 2021-08-01 13:28, Stefan Wahren wrote:
> Fix the node name to get the rid of the following DT schema warning:
> 'emmc2bus' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)
> (@[0-9a-f]+)?$'
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>  arch/arm/boot/dts/bcm2711.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/bcm2711.dtsi 
> b/arch/arm/boot/dts/bcm2711.dtsi
> index b8a4096..afe0ef8 100644
> --- a/arch/arm/boot/dts/bcm2711.dtsi
> +++ b/arch/arm/boot/dts/bcm2711.dtsi
> @@ -405,7 +405,7 @@
>  	 * The firmware will find whether the emmc2bus alias is defined, and 
> if
>  	 * so, it'll edit the dma-ranges property below accordingly.
>  	 */
> -	emmc2bus: emmc2bus {
> +	emmc2bus: emmc2-bus {

There was a recent breakage on rk3399 because of a similar change.

This is a userspace visible change (it affects the sysfs paths),
which will break people's scripts. It would be a lot better to
add an annotation to the DT to acknowledge the issue and keep
the checker quiet.

         M.
-- 
Jazz is not dead. It just smells funny...

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Nicolas Saenz Julienne <nsaenz@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com,
	Maxime Ripard <maxime@cerno.tech>,
	devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/9] ARM: dts: bcm2711: fix emmc2bus node name
Date: Mon, 02 Aug 2021 11:25:24 +0100	[thread overview]
Message-ID: <1072417634cf20c7dc46e545e9fcd242@kernel.org> (raw)
In-Reply-To: <1627820932-7247-2-git-send-email-stefan.wahren@i2se.com>

On 2021-08-01 13:28, Stefan Wahren wrote:
> Fix the node name to get the rid of the following DT schema warning:
> 'emmc2bus' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)
> (@[0-9a-f]+)?$'
> 
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>  arch/arm/boot/dts/bcm2711.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/bcm2711.dtsi 
> b/arch/arm/boot/dts/bcm2711.dtsi
> index b8a4096..afe0ef8 100644
> --- a/arch/arm/boot/dts/bcm2711.dtsi
> +++ b/arch/arm/boot/dts/bcm2711.dtsi
> @@ -405,7 +405,7 @@
>  	 * The firmware will find whether the emmc2bus alias is defined, and 
> if
>  	 * so, it'll edit the dma-ranges property below accordingly.
>  	 */
> -	emmc2bus: emmc2bus {
> +	emmc2bus: emmc2-bus {

There was a recent breakage on rk3399 because of a similar change.

This is a userspace visible change (it affects the sysfs paths),
which will break people's scripts. It would be a lot better to
add an annotation to the DT to acknowledge the issue and keep
the checker quiet.

         M.
-- 
Jazz is not dead. It just smells funny...

  reply	other threads:[~2021-08-02 10:27 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-01 12:28 [PATCH 0/9] ARM: dts: Add Raspberry Pi CM4 & CM4 IO Board support Stefan Wahren
2021-08-01 12:28 ` Stefan Wahren
2021-08-01 12:28 ` [PATCH 1/9] ARM: dts: bcm2711: fix emmc2bus node name Stefan Wahren
2021-08-01 12:28   ` Stefan Wahren
2021-08-02 10:25   ` Marc Zyngier [this message]
2021-08-02 10:25     ` Marc Zyngier
2021-08-01 12:28 ` [PATCH 2/9] ARM: dts: bcm2711: fix MDIO #address- and #size-cells Stefan Wahren
2021-08-01 12:28   ` Stefan Wahren
2021-08-05  9:08   ` Florian Fainelli
2021-08-05  9:08     ` Florian Fainelli
2021-08-01 12:28 ` [PATCH 3/9] ARM: dts: bcm2711-rpi-4-b: fix sd_io_1v8_reg regulator states Stefan Wahren
2021-08-01 12:28   ` Stefan Wahren
2021-08-01 12:28 ` [PATCH 4/9] dt-bindings: display: bcm2835: add optional property power-domains Stefan Wahren
2021-08-01 12:28   ` Stefan Wahren
2021-08-06 21:11   ` Rob Herring
2021-08-06 21:11     ` Rob Herring
2021-08-01 12:28 ` [PATCH 5/9] ARM: dts: bcm283x-rpi: Move Wifi/BT into separate dtsi Stefan Wahren
2021-08-01 12:28   ` Stefan Wahren
2021-08-01 12:28 ` [PATCH 6/9] dt-bindings: arm: bcm2835: Add Raspberry Pi Compute Module 4 Stefan Wahren
2021-08-01 12:28   ` Stefan Wahren
2021-08-06 21:12   ` Rob Herring
2021-08-06 21:12     ` Rob Herring
2021-08-01 12:28 ` [PATCH 7/9] ARM: dts: " Stefan Wahren
2021-08-01 12:28   ` Stefan Wahren
2021-08-01 12:28 ` [PATCH 8/9] ARM: dts: Add Raspberry Pi Compute Module 4 IO Board Stefan Wahren
2021-08-01 12:28   ` Stefan Wahren
2021-08-01 12:28 ` [PATCH 9/9] arm64: dts: broadcom: Add reference to RPi CM4 " Stefan Wahren
2021-08-01 12:28   ` Stefan Wahren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1072417634cf20c7dc46e545e9fcd242@kernel.org \
    --to=maz@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=maxime@cerno.tech \
    --cc=nsaenz@kernel.org \
    --cc=rjui@broadcom.com \
    --cc=robh+dt@kernel.org \
    --cc=sbranden@broadcom.com \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.