From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 002FDC4338F for ; Mon, 2 Aug 2021 10:27:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2C4A60F6E for ; Mon, 2 Aug 2021 10:27:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C2C4A60F6E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qKR/Ee9jotx+4zk1YxVZSxhEy8mbhPl2i6yGe5OCO0w=; b=NehaaEJ0cwHHuPLfnVB4XkaAK4 I9KQpIaH3s1vKMAgsyADpK0b2VazY5GkjYWKM/MrpXJgWmYStU/Pz6SVihBIvKcRK0Gr2k0y0ieQB CiZOJIu/whwO8CiuktzHfziGDj7P9PgSrFRXRqwlSkyeBxphC1huXZygDEP3f7jVWzXfDdl/tsJBQ ch19Jbl/fnVS373NopEMydPGOxr0uRJ/4Iam1QriMVaBpxKMJlGb9OuSuN4ILTSTHfBzA5SwQaDtR Eujez4TjlAnhvQ4Fk5aac7O5te6pEohUiR/D8hV/JRwb3lgdOH9tdORX2dVpVVry7A1lqhcyh5FtG H1kU8p8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAV8U-00Fj6s-DG; Mon, 02 Aug 2021 10:25:30 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAV8Q-00Fj68-Nr; Mon, 02 Aug 2021 10:25:28 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5AB2360F6D; Mon, 2 Aug 2021 10:25:26 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mAV8O-002QL1-HD; Mon, 02 Aug 2021 11:25:24 +0100 MIME-Version: 1.0 Date: Mon, 02 Aug 2021 11:25:24 +0100 From: Marc Zyngier To: Stefan Wahren Cc: Rob Herring , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Maxime Ripard , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/9] ARM: dts: bcm2711: fix emmc2bus node name In-Reply-To: <1627820932-7247-2-git-send-email-stefan.wahren@i2se.com> References: <1627820932-7247-1-git-send-email-stefan.wahren@i2se.com> <1627820932-7247-2-git-send-email-stefan.wahren@i2se.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <1072417634cf20c7dc46e545e9fcd242@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: stefan.wahren@i2se.com, robh+dt@kernel.org, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, maxime@cerno.tech, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210802_032526_849789_B5F8A65E X-CRM114-Status: GOOD ( 19.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-08-01 13:28, Stefan Wahren wrote: > Fix the node name to get the rid of the following DT schema warning: > 'emmc2bus' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb) > (@[0-9a-f]+)?$' > > Signed-off-by: Stefan Wahren > --- > arch/arm/boot/dts/bcm2711.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/bcm2711.dtsi > b/arch/arm/boot/dts/bcm2711.dtsi > index b8a4096..afe0ef8 100644 > --- a/arch/arm/boot/dts/bcm2711.dtsi > +++ b/arch/arm/boot/dts/bcm2711.dtsi > @@ -405,7 +405,7 @@ > * The firmware will find whether the emmc2bus alias is defined, and > if > * so, it'll edit the dma-ranges property below accordingly. > */ > - emmc2bus: emmc2bus { > + emmc2bus: emmc2-bus { There was a recent breakage on rk3399 because of a similar change. This is a userspace visible change (it affects the sysfs paths), which will break people's scripts. It would be a lot better to add an annotation to the DT to acknowledge the issue and keep the checker quiet. M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96DCAC4338F for ; Mon, 2 Aug 2021 10:25:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7483460F70 for ; Mon, 2 Aug 2021 10:25:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233081AbhHBKZf (ORCPT ); Mon, 2 Aug 2021 06:25:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:52424 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232973AbhHBKZf (ORCPT ); Mon, 2 Aug 2021 06:25:35 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5AB2360F6D; Mon, 2 Aug 2021 10:25:26 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mAV8O-002QL1-HD; Mon, 02 Aug 2021 11:25:24 +0100 MIME-Version: 1.0 Date: Mon, 02 Aug 2021 11:25:24 +0100 From: Marc Zyngier To: Stefan Wahren Cc: Rob Herring , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Maxime Ripard , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/9] ARM: dts: bcm2711: fix emmc2bus node name In-Reply-To: <1627820932-7247-2-git-send-email-stefan.wahren@i2se.com> References: <1627820932-7247-1-git-send-email-stefan.wahren@i2se.com> <1627820932-7247-2-git-send-email-stefan.wahren@i2se.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <1072417634cf20c7dc46e545e9fcd242@kernel.org> X-Sender: maz@kernel.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: stefan.wahren@i2se.com, robh+dt@kernel.org, nsaenz@kernel.org, f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com, maxime@cerno.tech, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2021-08-01 13:28, Stefan Wahren wrote: > Fix the node name to get the rid of the following DT schema warning: > 'emmc2bus' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb) > (@[0-9a-f]+)?$' > > Signed-off-by: Stefan Wahren > --- > arch/arm/boot/dts/bcm2711.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/bcm2711.dtsi > b/arch/arm/boot/dts/bcm2711.dtsi > index b8a4096..afe0ef8 100644 > --- a/arch/arm/boot/dts/bcm2711.dtsi > +++ b/arch/arm/boot/dts/bcm2711.dtsi > @@ -405,7 +405,7 @@ > * The firmware will find whether the emmc2bus alias is defined, and > if > * so, it'll edit the dma-ranges property below accordingly. > */ > - emmc2bus: emmc2bus { > + emmc2bus: emmc2-bus { There was a recent breakage on rk3399 because of a similar change. This is a userspace visible change (it affects the sysfs paths), which will break people's scripts. It would be a lot better to add an annotation to the DT to acknowledge the issue and keep the checker quiet. M. -- Jazz is not dead. It just smells funny...