All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@steeleye.com>
To: "Hammer, Jack" <Jack_Hammer@adaptec.com>
Cc: Christoph Hellwig <hch@infradead.org>,
	Xose Vazquez Perez <xose@wanadoo.es>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	Tosatti <marcelo.tosatti@cyclades.com>
Subject: RE: [PATCH] ips driver for 2.4.23-pre4
Date: 08 Jan 2004 16:16:29 -0500	[thread overview]
Message-ID: <1073596589.2915.276.camel@mulgrave> (raw)
In-Reply-To: <A121ABA5B472B74EB59076B8E3C8F0190129F3@rtpe2k01.adaptec.com>

On Thu, 2004-01-08 at 15:18, Hammer, Jack wrote:
> The reason this compiler warning exists is that these are the only hardware
> platforms that support this adapter.  Use of this adapter is any other box
> can cause serious problems and is not supported by anyone.  Removal of this
> warning has no effect on the executable code and would not improve the
> driver in my opinion.  If I was including a module in my system that is not
> going to work, I'd like to know about it.
[...]
> > -#if !defined(__i386__) && !defined(__ia64__) -#error "This driver has 
> > only been tested on the x86/ia64 platforms"
> > +#if !defined(__i386__) && !defined(__ia64__) && !defined(__x86_64__) 
> > +#error "This driver has only been tested on the x86/ia64/x86_64
> platforms"
> >  #endif

This is actually an #error though, not a #warning...could we at least
downgrade it to #warning (like has already been done for ips) so I don't
get spurious compile failure reports from people doing make allyes
configurations on non-x86 boxes?

Thanks,

James



  reply	other threads:[~2004-01-08 21:16 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-08 20:18 [PATCH] ips driver for 2.4.23-pre4 Hammer, Jack
2004-01-08 21:16 ` James Bottomley [this message]
2004-01-09 12:35   ` Marcelo Tosatti
  -- strict thread matches above, loose matches on Subject: below --
2004-01-09 12:35 Hammer, Jack
2004-01-07 19:17 Xose Vazquez Perez
2004-01-07 20:47 ` Xose Vazquez Perez
2004-01-08 17:15 ` Christoph Hellwig
2004-01-08 18:18   ` Xose Vazquez Perez
2004-01-08 18:21     ` Christoph Hellwig
2004-01-08 18:49       ` Xose Vazquez Perez
2004-01-08 19:06         ` Arjan van de Ven
2004-01-08 19:30           ` Xose Vazquez Perez
2004-01-08 19:36             ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1073596589.2915.276.camel@mulgrave \
    --to=james.bottomley@steeleye.com \
    --cc=Jack_Hammer@adaptec.com \
    --cc=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=xose@wanadoo.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.