From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andrew Morton <akpm@osdl.org>
Cc: ramon.rey@hispalinux.es, ramon.rey@augcyl.org,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [2.6.1-rc2-mm1][BUG] Badness in unblank_screen at drivers/char/vt.c:2793
Date: Fri, 09 Jan 2004 11:10:28 +1100 [thread overview]
Message-ID: <1073607026.4067.178.camel@gaston> (raw)
In-Reply-To: <20040108155940.68ab047a.akpm@osdl.org>
> Ben, your debug stuff tripped up when we were oopsing. bust_spinlocks()
> calls unblank_screen() without console_sem. I'll change it to
>
> WARN_ON(!is_console_locked() && !oops_in_progress);
>
> (Weren't you going to update that patch anyway?)
I don't have an update ready at the moment, nothing critical need
updating and I was waiting to see if the WARN_ON would catch some
stuffs :)
It's probably worth adding a WARN_CONSOLE_UNLOCKED() macro that
does the above rather than fixing all the WARN_ON's don't you
think ? If yes, then I'll do a new patch.
> As for the oops itself: 2.6.1-rc2-mm1 VM is kaput, sorry. It works OK here
> without the fremap changes.
Ok.
next prev parent reply other threads:[~2004-01-09 0:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-08 23:45 [2.6.1-rc2-mm1][BUG] Badness in unblank_screen at drivers/char/vt.c:2793 Ramon Rey Vicente
2004-01-08 23:59 ` Andrew Morton
2004-01-09 0:10 ` Benjamin Herrenschmidt [this message]
2004-01-09 0:18 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1073607026.4067.178.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ramon.rey@augcyl.org \
--cc=ramon.rey@hispalinux.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.