From: James Bottomley <James.Bottomley@steeleye.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Intel Alder IOAPIC fix
Date: 12 Jan 2004 19:25:03 -0500 [thread overview]
Message-ID: <1073953504.2078.92.camel@mulgrave> (raw)
In-Reply-To: <Pine.LNX.4.58.0401121452340.2031@evo.osdl.org>
On Mon, 2004-01-12 at 18:04, Linus Torvalds wrote:
> for (i = 0; i < 6; i++) {
> if (!pci_resource_start(dev, i))
> continue;
> if (!pci_resource_len(dev, i))
> continue;
Unfortunately this won't work because of the properties of insert
resource. The BAR covers the second IO APIC at fec01000-fec013ff.
However, this sits right in the middle of the fixmap region:
fec00000-fec08fff : reserved
This check in insert_resource makes sure that the resource being
inserted has to end beyond the resource it is replacing:
/* existing resource overlaps end of new resource */
if (next->end > new->end)
goto out;
I could hack up another insert resource function that would put the
resource *under* anything else it finds (i.e. the reserved region).
Otherwise, everything will work since the i386 pci code assumes that if
the resource already has a parent, it has already been correctly
assigned, so won't try to reassign it.
James
next prev parent reply other threads:[~2004-01-13 0:25 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-12 2:55 [PATCH] Intel Alder IOAPIC fix James Bottomley
2004-01-12 21:24 ` Linus Torvalds
2004-01-12 22:13 ` James Bottomley
2004-01-12 23:04 ` James Bottomley
2004-01-12 23:04 ` Linus Torvalds
2004-01-13 0:25 ` James Bottomley [this message]
2004-01-13 0:45 ` James Bottomley
2004-01-13 0:25 ` Linus Torvalds
2004-01-13 16:52 ` James Bottomley
2004-01-15 5:18 ` Eric W. Biederman
2004-01-15 16:58 ` James Bottomley
2004-01-15 19:26 ` Eric W. Biederman
2004-01-15 19:54 ` James Bottomley
2004-01-16 5:32 ` Eric W. Biederman
2004-01-17 15:18 ` James Bottomley
2004-01-17 19:43 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1073953504.2078.92.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.