Re: [Bluez-devel] Re: Reproducible kernel oops on PPP session start

[Marcel Holtmann <marcel@holtmann.org>]

[-- Attachment #1: Type: text/plain, Size: 645 bytes --]

Hi Eugene,

> This means that the termination of an incoming RFCOMM connections
> decrements the reference counting of the L2CAP module. This should not
> happen and I think we have a wrong owner entry somewhere in the RFCOMM
> socket code, but at the moment I don't know where.

actually it is not a wrong owner entry. But the RFCOMM core layer have
to increment the module reference count of the L2CAP module, when we
accept a new incoming L2CAP connection. I am not 100% that this is the
right way to fix this problem, but for me it works. Please check if the
attached patch helps and don't breaks any other of your setups.

Regards

Marcel


[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 340 bytes --]

--- 1.32/net/bluetooth/rfcomm/core.c	Fri Dec 19 19:44:32 2003
+++ edited/net/bluetooth/rfcomm/core.c	Tue Jan 13 20:25:56 2004
@@ -1649,7 +1649,9 @@
 
 	nsock->type = sock->type;
 	nsock->ops  = sock->ops;
-	
+
+	__module_get(nsock->ops->owner);
+
 	err = sock->ops->accept(sock, nsock, O_NONBLOCK);
 	if (err < 0) {
 		sock_release(nsock);