From: Robert Love <rml@ximian.com>
To: joe.korty@ccur.com, akpm@digeo.com
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rq->curr==p not equivalent to task_running(rq,p)
Date: Tue, 13 Jan 2004 18:49:22 -0500 [thread overview]
Message-ID: <1074037762.1153.887.camel@localhost> (raw)
In-Reply-To: <20040113230220.GA13341@tsunami.ccur.com>
On Tue, 2004-01-13 at 18:02, Joe Korty wrote:
> task_running(rq,p) is equivalent to (rq->curr == p) only for some
> architectures. Boot tested on i386.
Oh, good catch.
Andrew, mind taking this?
Thanks, Joe.
Robert Love
diff -Nua 2.6/kernel/sched.c.0 2.6/kernel/sched.c
--- 2.6/kernel/sched.c.0 2004-01-13 17:53:34.000000000 -0500
+++ 2.6/kernel/sched.c 2004-01-13 17:47:33.000000000 -0500
@@ -2062,7 +2062,7 @@
* our priority decreased, or if we are not currently running on
* this runqueue and our priority is higher than the current's
*/
- if (rq->curr == p) {
+ if (task_running(rq, p)) {
if (p->prio > oldprio)
resched_task(rq->curr);
} else if (p->prio < rq->curr->prio)
next prev parent reply other threads:[~2004-01-13 23:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-13 23:02 [PATCH] rq->curr==p not equivalent to task_running(rq,p) Joe Korty
2004-01-13 23:49 ` Robert Love [this message]
2004-01-14 8:55 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1074037762.1153.887.camel@localhost \
--to=rml@ximian.com \
--cc=akpm@digeo.com \
--cc=joe.korty@ccur.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.