Re: Re: [PATCH] kyrofb support

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

> In general, what are the fbdev drivers doing here btw?  It's very strange
> that some core file (fbmem.c) has to "know" about individual card drivers. 
> It should be sufficient for the driver to just register itself with the core
> at the drivers's module_init() time.
> 
> Sigh.  Too late to fix that now I guess.

Pre-historical junk that should be killed for 2.7 (I hope).

There isn't that a bad internal API change, the main of it is the allocation
and freeing of the fbdev, adapting the driver to that should be trivial. I
hope James will feed you with the new stuff asap now. Most of my concerns
about the core stuff are adressed at this point (though I didn't look at
individual drivers). The fbcon resize stuff is still broken in subtle ways,
but that shouldn't prevent merging what we have now.

Ben.




-------------------------------------------------------
This SF.net email is sponsored by: Perforce Software.
Perforce is the Fast Software Configuration Management System offering
advanced branching capabilities and atomic changes on 50+ platforms.
Free Eval! http://www.perforce.com/perforce/loadprog.html