From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90C3AC2D0E4 for ; Sun, 15 Nov 2020 10:52:08 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 5561023A32 for ; Sun, 15 Nov 2020 10:52:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5561023A32 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B8CD0493D; Sun, 15 Nov 2020 11:52:04 +0100 (CET) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id E9F45323E for ; Sun, 15 Nov 2020 11:52:01 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 680EB5C009A; Sun, 15 Nov 2020 05:52:00 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 15 Nov 2020 05:52:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= r3pUiszkAvOi6loDH3a+BBPRwUSwQeRD7DPwsE9gtWM=; b=vICJ4GBGYAlJClrZ vP/482JPnENwpa27hly4xw7hbp8cpDQ5Kqk5RS3zrhDUgAk1lmejQAn29u2SKR7/ h/hOsMgASn0hsBxyzdqSF5jQHcIRe36ykzYXygeKEawcta7s2qLlSRbokZf/RMR5 qF6dM7d9ABJvE4C9y02y4jfK96WE3Yuv8V0fHBcV5NCcyY1uw+YNtYwPenn7X6RU +Bw1pArOUFVaEqY2xan7uOJxRFqtophGtxiE2H5cbYAjjIAzGfLgoIX3rDYGsW5A iVU7UEdIQi5Uw+5E40lYhWWgMAy3AIJL6ttWiBAhmar2avFadDIpbk3syl7SDULG k6E6oQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=r3pUiszkAvOi6loDH3a+BBPRwUSwQeRD7DPwsE9gt WM=; b=EJBjJ6PfLjnOXMfxX3wKAQZsxLmQQ6e00eJ0oJOgRnWqudHSLsQazkafL 0isMEZPaGHQQ5RF/GYtscPu5aDZN717d3AiZsHfNpMaoo0vBg32vrkS43e3zd1N4 TFnYkf3cafAvntReC1s8dXsQ8xOVtiTjMT1YLJ/BEBYfWSkzssbPHCQG8RgpGPqh ixEdIWOKq0lg/vUXgyxusTQqSol90DHw87NoUbxN3/rxQwmbwU02U4QeGin90a3J 3O7vewJDMVxr2mYk5rIDTkTCohRZkgK3IYc9AnMrvRKga1bfa7yEeGIew6glN/58 UHJllnNCTb0ynRVu6KO5jwGzjiKcA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddvledgvddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id E8276328005E; Sun, 15 Nov 2020 05:51:58 -0500 (EST) From: Thomas Monjalon To: Tal Shnaiderman Cc: Dmitry Kozlyuk , "dev@dpdk.org" , "navasile@linux.microsoft.com" , "dmitrym@microsoft.com" , "pallavi.kadam@intel.com" Date: Sun, 15 Nov 2020 11:51:57 +0100 Message-ID: <10748722.TlkrfTdTIa@thomas> In-Reply-To: References: <20201114211156.17196-1-talshn@nvidia.com> <20201115010155.06bcd0ea@sovereign> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal/windows: definition for ETOOMANYREFS errno X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/11/2020 23:11, Tal Shnaiderman: > > On Sat, 14 Nov 2020 23:11:56 +0200, Tal Shnaiderman wrote: > > > The ETOOMANYREFS errno is missing from the Windows clang build is it > > > used in initialization of flow error structures. > > > > "is it" -> "it is" > > > > > The commit will define it as it is done in the minGW Windows build. > > > > "The commit will" is unnecessary. > > > > "minGW" -> "MinGW" [...] > Thank you for the comments Dmitry, will send a v2 promptly. Just a detail, I see you missed this comment in v2: "The commit will" is unnecessary.