From: Len Brown <len.brown-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Jes Sorensen <jes-dtAfj9ClZIwnoBwkMbRkTB2eb7JE58TQ@public.gmane.org>
Cc: ACPI Developers
<acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [patch] remove null-ifiers
Date: 26 Jan 2004 15:58:36 -0500 [thread overview]
Message-ID: <1075150716.2484.32.camel@dhcppc4> (raw)
In-Reply-To: <E1AgkrW-00080w-00-uLT3q8aHQDsX9StFTm9pZA@public.gmane.org>
Accepted.
thanks,
-Len
On Wed, 2004-01-14 at 08:15, Jes Sorensen wrote:
> Hi,
>
> The included patch removes a number of NULL-ilizers from the ACPI code
> resulting in variables being put in the data segment instead of the bss
> segment.
>
> Patch is relative to Andrew's 2.6.1-mm3 patch.
>
> Cheers,
> Jes
>
> diff -urN -X /usr/people/jes/exclude-linux orig/linux-2.6.1-mm3-boot/drivers/acpi/ac.c linux-2.6.1-mm3/drivers/acpi/ac.c
> --- orig/linux-2.6.1-mm3-boot/drivers/acpi/ac.c Wed Dec 17 18:58:47 2003
> +++ linux-2.6.1-mm3/drivers/acpi/ac.c Wed Jan 14 04:55:10 2004
> @@ -108,7 +108,7 @@
> FS Interface (/proc)
> -------------------------------------------------------------------------- */
>
> -struct proc_dir_entry *acpi_ac_dir = NULL;
> +struct proc_dir_entry *acpi_ac_dir;
>
> int acpi_ac_seq_show(struct seq_file *seq, void *offset)
> {
> diff -urN -X /usr/people/jes/exclude-linux orig/linux-2.6.1-mm3-boot/drivers/acpi/asus_acpi.c linux-2.6.1-mm3/drivers/acpi/asus_acpi.c
> --- orig/linux-2.6.1-mm3-boot/drivers/acpi/asus_acpi.c Wed Dec 17 18:58:39 2003
> +++ linux-2.6.1-mm3/drivers/acpi/asus_acpi.c Wed Jan 14 05:00:01 2004
> @@ -73,8 +73,8 @@
> MODULE_LICENSE("GPL");
>
>
> -static uid_t asus_uid = 0;
> -static gid_t asus_gid = 0;
> +static uid_t asus_uid;
> +static gid_t asus_gid;
> MODULE_PARM(asus_uid, "i");
> MODULE_PARM_DESC(uid, "UID for entries in /proc/acpi/asus.\n");
> MODULE_PARM(asus_gid, "i");
> @@ -192,14 +192,14 @@
> };
>
> /* procdir we use */
> -static struct proc_dir_entry *asus_proc_dir = NULL;
> +static struct proc_dir_entry *asus_proc_dir;
>
> /*
> * This header is made available to allow proper configuration given model,
> * revision number , ... this info cannot go in struct asus_hotk because it is
> * available before the hotk
> */
> -static struct acpi_table_header *asus_info = NULL;
> +static struct acpi_table_header *asus_info;
>
> /*
> * The hotkey driver declaration
> diff -urN -X /usr/people/jes/exclude-linux orig/linux-2.6.1-mm3-boot/drivers/acpi/battery.c linux-2.6.1-mm3/drivers/acpi/battery.c
> --- orig/linux-2.6.1-mm3-boot/drivers/acpi/battery.c Wed Dec 17 18:59:17 2003
> +++ linux-2.6.1-mm3/drivers/acpi/battery.c Wed Jan 14 04:56:10 2004
> @@ -340,7 +340,7 @@
> FS Interface (/proc)
> -------------------------------------------------------------------------- */
>
> -struct proc_dir_entry *acpi_battery_dir = NULL;
> +struct proc_dir_entry *acpi_battery_dir;
>
> static int
> acpi_battery_read_info (
> diff -urN -X /usr/people/jes/exclude-linux orig/linux-2.6.1-mm3-boot/drivers/acpi/button.c linux-2.6.1-mm3/drivers/acpi/button.c
> --- orig/linux-2.6.1-mm3-boot/drivers/acpi/button.c Wed Dec 17 18:58:06 2003
> +++ linux-2.6.1-mm3/drivers/acpi/button.c Wed Jan 14 04:56:39 2004
> @@ -107,7 +107,7 @@
> FS Interface (/proc)
> -------------------------------------------------------------------------- */
>
> -static struct proc_dir_entry *acpi_button_dir = NULL;
> +static struct proc_dir_entry *acpi_button_dir;
>
> static int acpi_button_info_seq_show(struct seq_file *seq, void *offset)
> {
> diff -urN -X /usr/people/jes/exclude-linux orig/linux-2.6.1-mm3-boot/drivers/acpi/ec.c linux-2.6.1-mm3/drivers/acpi/ec.c
> --- orig/linux-2.6.1-mm3-boot/drivers/acpi/ec.c Wed Dec 17 18:58:56 2003
> +++ linux-2.6.1-mm3/drivers/acpi/ec.c Wed Jan 14 04:57:01 2004
> @@ -475,7 +475,7 @@
> FS Interface (/proc)
> -------------------------------------------------------------------------- */
>
> -struct proc_dir_entry *acpi_ec_dir = NULL;
> +struct proc_dir_entry *acpi_ec_dir;
>
>
> static int
> diff -urN -X /usr/people/jes/exclude-linux orig/linux-2.6.1-mm3-boot/drivers/acpi/fan.c linux-2.6.1-mm3/drivers/acpi/fan.c
> --- orig/linux-2.6.1-mm3-boot/drivers/acpi/fan.c Wed Dec 17 18:58:07 2003
> +++ linux-2.6.1-mm3/drivers/acpi/fan.c Wed Jan 14 04:57:17 2004
> @@ -71,7 +71,7 @@
> FS Interface (/proc)
> -------------------------------------------------------------------------- */
>
> -struct proc_dir_entry *acpi_fan_dir = NULL;
> +struct proc_dir_entry *acpi_fan_dir;
>
>
> static int
> diff -urN -X /usr/people/jes/exclude-linux orig/linux-2.6.1-mm3-boot/drivers/acpi/osl.c linux-2.6.1-mm3/drivers/acpi/osl.c
> --- orig/linux-2.6.1-mm3-boot/drivers/acpi/osl.c Wed Jan 14 02:59:49 2004
> +++ linux-2.6.1-mm3/drivers/acpi/osl.c Wed Jan 14 05:00:25 2004
> @@ -59,13 +59,13 @@
> #ifdef ENABLE_DEBUGGER
> #include <linux/kdb.h>
> /* stuff for debugger support */
> -int acpi_in_debugger = 0;
> +int acpi_in_debugger;
> extern char line_buf[80];
> #endif /*ENABLE_DEBUGGER*/
>
> -static int acpi_irq_irq = 0;
> -static OSD_HANDLER acpi_irq_handler = NULL;
> -static void *acpi_irq_context = NULL;
> +static int acpi_irq_irq;
> +static OSD_HANDLER acpi_irq_handler;
> +static void *acpi_irq_context;
>
> acpi_status
> acpi_os_initialize(void)
> diff -urN -X /usr/people/jes/exclude-linux orig/linux-2.6.1-mm3-boot/drivers/acpi/power.c linux-2.6.1-mm3/drivers/acpi/power.c
> --- orig/linux-2.6.1-mm3-boot/drivers/acpi/power.c Wed Dec 17 18:58:56 2003
> +++ linux-2.6.1-mm3/drivers/acpi/power.c Wed Jan 14 04:58:13 2004
> @@ -387,7 +387,7 @@
> FS Interface (/proc)
> -------------------------------------------------------------------------- */
>
> -struct proc_dir_entry *acpi_power_dir = NULL;
> +struct proc_dir_entry *acpi_power_dir;
>
> static int acpi_power_seq_show(struct seq_file *seq, void *offset)
> {
> diff -urN -X /usr/people/jes/exclude-linux orig/linux-2.6.1-mm3-boot/drivers/acpi/processor.c linux-2.6.1-mm3/drivers/acpi/processor.c
> --- orig/linux-2.6.1-mm3-boot/drivers/acpi/processor.c Wed Dec 17 18:59:05 2003
> +++ linux-2.6.1-mm3/drivers/acpi/processor.c Wed Jan 14 04:58:27 2004
> @@ -138,7 +138,7 @@
>
> static struct acpi_processor *processors[NR_CPUS];
> static struct acpi_processor_errata errata;
> -static void (*pm_idle_save)(void) = NULL;
> +static void (*pm_idle_save)(void);
>
>
> /* --------------------------------------------------------------------------
> diff -urN -X /usr/people/jes/exclude-linux orig/linux-2.6.1-mm3-boot/drivers/acpi/thermal.c linux-2.6.1-mm3/drivers/acpi/thermal.c
> --- orig/linux-2.6.1-mm3-boot/drivers/acpi/thermal.c Wed Jan 14 02:59:49 2004
> +++ linux-2.6.1-mm3/drivers/acpi/thermal.c Wed Jan 14 04:59:18 2004
> @@ -74,7 +74,7 @@
> MODULE_DESCRIPTION(ACPI_THERMAL_DRIVER_NAME);
> MODULE_LICENSE("GPL");
>
> -static int tzp = 0;
> +static int tzp;
> MODULE_PARM(tzp, "i");
> MODULE_PARM_DESC(tzp, "Thermal zone polling frequency, in 1/10 seconds.\n");
>
> @@ -766,7 +766,7 @@
> FS Interface (/proc)
> -------------------------------------------------------------------------- */
>
> -struct proc_dir_entry *acpi_thermal_dir = NULL;
> +struct proc_dir_entry *acpi_thermal_dir;
>
> static int acpi_thermal_state_seq_show(struct seq_file *seq, void *offset)
> {
> diff -urN -X /usr/people/jes/exclude-linux orig/linux-2.6.1-mm3-boot/drivers/acpi/toshiba_acpi.c linux-2.6.1-mm3/drivers/acpi/toshiba_acpi.c
> --- orig/linux-2.6.1-mm3-boot/drivers/acpi/toshiba_acpi.c Wed Dec 17 18:58:07 2003
> +++ linux-2.6.1-mm3/drivers/acpi/toshiba_acpi.c Wed Jan 14 04:59:33 2004
> @@ -215,7 +215,7 @@
> return status;
> }
>
> -static struct proc_dir_entry* toshiba_proc_dir = NULL;
> +static struct proc_dir_entry* toshiba_proc_dir;
> static int force_fan;
> static int last_key_event;
> static int key_event_valid;
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
next prev parent reply other threads:[~2004-01-26 20:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-14 13:15 [patch] remove null-ifiers Jes Sorensen
[not found] ` <E1AgkrW-00080w-00-uLT3q8aHQDsX9StFTm9pZA@public.gmane.org>
2004-01-26 20:58 ` Len Brown [this message]
2004-01-27 15:09 ` Karol Kozimor
[not found] ` <20040127150954.GA12740-DETuoxkZsSqrDJvtcaxF/A@public.gmane.org>
2004-01-27 15:15 ` Jes Sorensen
[not found] ` <16406.32889.922823.45313-4mDQ13Tdud8Jw5R7aSpS0dP8p4LwMBBS@public.gmane.org>
2004-01-27 15:31 ` John Belmonte
[not found] ` <40168442.7020806-wanGne27zNesTnJN9+BGXg@public.gmane.org>
2004-01-27 15:35 ` Jes Sorensen
[not found] ` <16406.34107.51859.924117-4mDQ13Tdud8Jw5R7aSpS0dP8p4LwMBBS@public.gmane.org>
2004-01-30 7:09 ` Nate Lawson
2004-01-30 14:54 ` Matthew Wilcox
2004-01-27 21:29 ` Karol Kozimor
2004-01-27 15:43 ` Matthew Wilcox
[not found] ` <20040127154314.GY11844-+pPCBgu9SkPzIGdyhVEDUDl5KyyQGfY2kSSpQ9I8OhVaa/9Udqfwiw@public.gmane.org>
2004-01-27 16:44 ` Yury V. Umanets
2004-01-27 20:04 ` Nate Lawson
[not found] ` <20040127120357.X37323-Y6VGUYTwhu0@public.gmane.org>
2004-01-27 20:07 ` Karol Kozimor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1075150716.2484.32.camel@dhcppc4 \
--to=len.brown-ral2jqcrhueavxtiumwx3w@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=jes-dtAfj9ClZIwnoBwkMbRkTB2eb7JE58TQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.