All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Jeff Sutherland <jeffs@fairwayacademy.org>
Cc: BlueZ Mailing List <bluez-users@lists.sourceforge.net>
Subject: Re: [Bluez-users] Timeout message from kernel
Date: Sat, 14 Feb 2004 16:02:39 +0100	[thread overview]
Message-ID: <1076770958.14758.5.camel@pegasus> (raw)
In-Reply-To: <200402140859.36255.jeffs@fairwayacademy.org>

[-- Attachment #1: Type: text/plain, Size: 516 bytes --]

Hi Jeff,

> > maybe we really have some endian problems here and also in hcitool. The
> > pkt_type for create_connection is for example uint16 and this explains
> > why "hcitool info ..." fails. I don't have access to a machine with big
> > endian, so most of the userspace tools are not fully tested.
> 
>  I'll have access to this machine for a little while, so if you have something 
> you'd like to try just send patches this way :-)

try this one to solve the problem with "hcitool info ...".

Regards

Marcel


[-- Attachment #2: patch --]
[-- Type: text/x-patch, Size: 919 bytes --]

Index: hcitool.c
===================================================================
RCS file: /cvsroot/bluez/utils/tools/hcitool.c,v
retrieving revision 1.35
diff -u -r1.35 hcitool.c
--- hcitool.c	21 Dec 2003 16:08:25 -0000	1.35
+++ hcitool.c	14 Feb 2004 14:56:52 -0000
@@ -436,7 +436,7 @@
 	bacpy(&cr->bdaddr, &bdaddr);
 	cr->type = ACL_LINK;
 	if (ioctl(dd, HCIGETCONNINFO, (unsigned long) cr) < 0) {
-		if (hci_create_connection(dd, &bdaddr, HCI_DM1 | HCI_DH1, 0, 0, &handle, 25000) < 0) {
+		if (hci_create_connection(dd, &bdaddr, htobs(HCI_DM1 | HCI_DH1), 0, 0, &handle, 25000) < 0) {
 			perror("Can't create connection");
 			close(dd);
 			exit(1);
@@ -653,7 +653,7 @@
 		exit(1);
 	}
 
-	if (hci_create_connection(dd, &bdaddr, ptype, 0, role, &handle, 1000) < 0)
+	if (hci_create_connection(dd, &bdaddr, htobs(ptype), 0, role, &handle, 1000) < 0)
 		perror("Can't create connection");
 	hci_close_dev(dd);
 }

  reply	other threads:[~2004-02-14 15:02 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-12 21:36 [Bluez-users] Timeout message from kernel Jeff Sutherland
2004-02-13  0:14 ` Marcel Holtmann
2004-02-13 14:17   ` Jeff Sutherland
2004-02-13 14:22     ` Marcel Holtmann
2004-02-13 15:23       ` Jeff Sutherland
2004-02-13 15:28         ` Marcel Holtmann
2004-02-13 23:19           ` Jeff Sutherland
2004-02-13 23:40             ` Marcel Holtmann
2004-02-13 23:58               ` Jeff Sutherland
2004-02-14  0:06                 ` Marcel Holtmann
2004-02-14  4:10                   ` Jeff Sutherland
2004-02-14  8:53                     ` Marcel Holtmann
2004-02-14 13:59                       ` Jeff Sutherland
2004-02-14 15:02                         ` Marcel Holtmann [this message]
2004-02-15 22:43                           ` Jeff Sutherland
2004-02-15 23:36                             ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1076770958.14758.5.camel@pegasus \
    --to=marcel@holtmann.org \
    --cc=bluez-users@lists.sourceforge.net \
    --cc=jeffs@fairwayacademy.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.