From: Marcel Holtmann <marcel@holtmann.org>
To: Jeff Sutherland <jeffs@fairwayacademy.org>
Cc: BlueZ Mailing List <bluez-users@lists.sourceforge.net>
Subject: Re: [Bluez-users] Mysterious problem with l2test on Coldfire 5282
Date: Tue, 17 Feb 2004 19:35:56 +0100 [thread overview]
Message-ID: <1077042956.2665.85.camel@pegasus> (raw)
In-Reply-To: <200402171126.46462.jeffs@fairwayacademy.org>
Hi Jeff,
> > maybe this code in send_mode() is the problem
> >
> > *(uint32_t *) buf = htobl(seq++);
> > *(uint16_t *)(buf+4) = htobs(data_size);
> >
> > Replace it with
> >
> > *(uint32_t *) buf = htobl(seq);
> > *(uint16_t *)(buf+4) = htobs(data_size);
> > seq++;
> >
> > I am not a uClinux or compiler expert, so this is only guess.
>
> Oh, Doh! I'm sure this is it (haven't tried it yet, though) because of the
> way the byteswap_32() macro expands! No fair doing increment/decrement ops
> on variables inside macros :-)
I applied the fix for l2test, rctest and scotest. Should be in CVS now.
Regards
Marcel
-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
_______________________________________________
Bluez-users mailing list
Bluez-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-users
next prev parent reply other threads:[~2004-02-17 18:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-17 14:24 [Bluez-users] Mysterious problem with l2test on Coldfire 5282 Jeff Sutherland
2004-02-17 15:43 ` Marcel Holtmann
2004-02-17 16:26 ` Jeff Sutherland
2004-02-17 18:35 ` Marcel Holtmann [this message]
2004-02-17 21:47 ` Jeff Sutherland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1077042956.2665.85.camel@pegasus \
--to=marcel@holtmann.org \
--cc=bluez-users@lists.sourceforge.net \
--cc=jeffs@fairwayacademy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.