From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Hugang <hugang@soulinfo.com>
Cc: Linux Kernel list <linux-kernel@vger.kernel.org>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: ppc suspend rewrite using inline.
Date: Wed, 18 Feb 2004 18:41:39 +1100 [thread overview]
Message-ID: <1077090098.10665.121.camel@gaston> (raw)
In-Reply-To: <20040218153548.2690e905@localhost>
On Wed, 2004-02-18 at 18:35, Hugang wrote:
> Hi Ben:
>
> I has finished rewriten the suspend code by inline, The swsusp2 works
> fine without any problem, But pmdisk can't works, The problem that's,
> when resume the current is not same as suspend.
I don't understand why you write. Looking at your code, I don't see
the point. By mixing C and assembly the way you do, and using those
horrible inline asm constructs, you are basically making the code
worse, less readable, and prone for bugs. I don't think you should
even try going into that direction, it makes no sense.
> I think the code can reuse by sleep.
Same
> I think turn off mmu copyback page is important, but I has looked x86
> resume code, it do not.
Same
> Please take a look.
Please try to be clear.
> thanks.
prev parent reply other threads:[~2004-02-18 7:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-18 7:35 ppc suspend rewrite using inline Hugang
2004-02-18 7:41 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1077090098.10665.121.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=hugang@soulinfo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.