All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: James Courtier-Dutton <James@superbug.demon.co.uk>
Cc: BlueZ Mailing List <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] [PATCH] Fix some bugs in hcidump.
Date: Mon, 23 Feb 2004 08:42:21 +0100	[thread overview]
Message-ID: <1077522140.2832.70.camel@pegasus> (raw)
In-Reply-To: <40397111.7000903@superbug.demon.co.uk>

Hi James,

> Attached is a patch to apply to bluez-hcidump-1.5/parser/sdp.c
> 
> It fixes some of the printout.

please always do the diff againts the CVS version.

> --- sdp.c.org	2004-02-23 02:56:03.667767736 +0000
> +++ sdp.c	2004-02-23 03:15:48.787602136 +0000
> @@ -324,6 +324,7 @@
>  	printf("pat");
>  
>  	if (parse_de_hdr(frm, &n1) == SDP_DE_SEQ) {
> +	        len = frm->len;
>  		while (len - frm->len < n1 ) {
>  			if (parse_de_hdr(frm,&n2) == SDP_DE_UUID) {
>  				print_uuid(n2, frm);

Your change means this

		while (n1 > 0) {
			...
		}

If this is what you want then do it this way and remove unneeded
variables. Give me a short description what this changes do and why you
did this change.

Regards

Marcel




-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id=1356&alloc_id=3438&op=click
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

  reply	other threads:[~2004-02-23  7:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-23  3:18 [Bluez-devel] [PATCH] Fix some bugs in hcidump James Courtier-Dutton
2004-02-23  7:42 ` Marcel Holtmann [this message]
2004-02-23 13:41   ` James Courtier-Dutton
2004-02-23 14:04     ` Marcel Holtmann
2004-02-23 15:04       ` James Courtier-Dutton
2004-02-23 17:39         ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1077522140.2832.70.camel@pegasus \
    --to=marcel@holtmann.org \
    --cc=James@superbug.demon.co.uk \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.