All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kay Sievers <kay.sievers@vrfy.org>
To: linux-hotplug@vger.kernel.org
Subject: Re: Excess spaces in sysfs files
Date: Wed, 25 Feb 2004 22:49:44 +0000	[thread overview]
Message-ID: <1077749384.3224.22.camel@pim> (raw)
In-Reply-To: <403D12BC.40209@reactivated.net>

On Wed, 2004-02-25 at 22:25, Daniel Drake wrote:
> 1. Should these spaces be here? Are devices really identifying themselves with 
> spaces on the end? Or is this an issue with sysfs/similar.

It's common. Seems like vendors are just filling fixed length fields.
A lot of fields are 8 characters total length.

> 2. Should udev trim whitespace from the end of SYSFS{..} values (files), so 
> that keys such as
>    SYSFS{model} = "iPod"
> would match a file containing
>    "iPod            "
> 
> If the above behaviour is implemented, I would suggest having a second key 
> type, SYSFS_RAW{..} where whitespace is not trimmed. I am prepared to write a 
> patch for this.

Hey, udevinfo is so cute :)
I don't like the idea to try to be smart with the matching, but if we
really want this, I prefer to have it configurable in the config file. 


thanks,
Kay




-------------------------------------------------------
SF.Net is sponsored by: Speed Start Your Linux Apps Now.
Build and deploy apps & Web services for Linux with
a free DVD software kit from IBM. Click Now!
http://ads.osdn.com/?ad_id\x1356&alloc_id438&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

  reply	other threads:[~2004-02-25 22:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-25 21:25 Excess spaces in sysfs files Daniel Drake
2004-02-25 22:49 ` Kay Sievers [this message]
2004-02-28  0:22 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1077749384.3224.22.camel@pim \
    --to=kay.sievers@vrfy.org \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.