From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linux Arch list <linux-arch@vger.kernel.org>
Subject: More DMA API junk
Date: Tue, 16 Mar 2004 11:53:03 +1100 [thread overview]
Message-ID: <1079398383.1968.205.camel@gaston> (raw)
While fixing ppc for DaveM new stuff, I found a couple of things
that look strange (not directly related to the patch though)
- dma_is_consistent(dma_addr_t address) : Did somebody actually expect
anything useful out of this function ? AFAIK, it makes no sense. There
is simply no way an arch like ppc that use per-page cache-inhibit
mappings to do consistent memory will be able to tell you if a given
_DMA_ address is consistent... that makes no sense.
- dma_cache_sync(): What is that function supposed to do ? It's a
duplicate of the other sync() functions and David didn't even bother
turning it into _for_device/for_cpu... which is fine since it doesn't
even takes a struct device argument.
I vote for removing the 2 functions above. I suspect something using
them is broken anyway.
Ben.
next reply other threads:[~2004-03-16 0:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-16 0:53 Benjamin Herrenschmidt [this message]
2004-03-16 1:12 ` More DMA API junk James Bottomley
2004-03-16 1:32 ` Benjamin Herrenschmidt
2004-03-16 3:24 ` James Bottomley
2004-03-16 3:32 ` Benjamin Herrenschmidt
2004-03-16 3:48 ` James Bottomley
2004-03-16 3:53 ` Benjamin Herrenschmidt
2004-03-16 11:17 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1079398383.1968.205.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=linux-arch@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.