From: Andrew Cooper <andrew.cooper3@citrix.com>
To: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
xen-devel@lists.xenproject.org
Cc: Doug Goldstein <cardoe@cardoe.com>,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH v3 4/7] CI: write whole etc/issue for domU initrd
Date: Fri, 11 Apr 2025 22:07:28 +0100 [thread overview]
Message-ID: <107fe18c-e72c-49b4-8b48-e11817f2cf9b@citrix.com> (raw)
In-Reply-To: <526ec153b1cabc1d5b111be27ded8d0d4da5178a.1744403499.git-series.marmarek@invisiblethingslab.com>
On 11/04/2025 9:32 pm, Marek Marczykowski-Górecki wrote:
> diff --git a/automation/scripts/qubes-x86-64.sh b/automation/scripts/qubes-x86-64.sh
> index 861e302d845b..dd88a1398f2b 100755
> --- a/automation/scripts/qubes-x86-64.sh
> +++ b/automation/scripts/qubes-x86-64.sh
> @@ -182,7 +182,10 @@ ${domU_check}
> " > etc/local.d/xen.start
> chmod +x etc/local.d/xen.start
> echo "rc_verbose=yes" >> etc/rc.conf
> - sed -i -e 's/^Welcome/domU \0/' etc/issue
> + echo "domU Welcome to Alpine Linux 3.18
This 3.18 is going to go stale shortly.
Because of LOG_MSG="Welcome to Alpine Linux", the version doesn't matter.
Alpine does have /etc/os-release, but busybox's getty doesn't translate
\S.
https://github.com/brgl/busybox/blob/abbf17abccbf832365d9acf1c280369ba7d5f8b2/libbb/login.c#L84-L86
I'd suggest just dropping the 3.18.
Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
next prev parent reply other threads:[~2025-04-11 21:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 20:32 [PATCH v3 0/7] Several CI cleanups and improvements around initrd/rootfs Marek Marczykowski-Górecki
2025-04-11 20:32 ` [PATCH v3 1/7] CI: wait for Xen to start before waiting for test to complete Marek Marczykowski-Górecki
2025-04-11 20:37 ` Andrew Cooper
2025-04-11 20:32 ` [PATCH v3 2/7] CI: fix waiting for final test message Marek Marczykowski-Górecki
2025-04-11 20:37 ` Andrew Cooper
2025-04-11 20:32 ` [PATCH v3 3/7] CI: switch qubes runners to use console.exp Marek Marczykowski-Górecki
2025-04-11 20:40 ` Andrew Cooper
2025-04-11 20:43 ` Marek Marczykowski-Górecki
2025-04-11 20:32 ` [PATCH v3 4/7] CI: write whole etc/issue for domU initrd Marek Marczykowski-Górecki
2025-04-11 21:07 ` Andrew Cooper [this message]
2025-04-11 22:52 ` Marek Marczykowski-Górecki
2025-04-11 20:32 ` [PATCH v3 5/7] CI: avoid repacking initrd as part of the test job Marek Marczykowski-Górecki
2025-04-12 14:05 ` Andrew Cooper
2025-04-12 14:19 ` Marek Marczykowski-Górecki
2025-04-12 16:42 ` Andrew Cooper
2025-04-11 20:32 ` [PATCH v3 7/7] CI: save toolstack artifact as cpio.gz Marek Marczykowski-Górecki
2025-04-11 20:32 ` [PATCH test-artifacts v3 8/7] Enable CONFIG_USB_RTL8152 in kernel for hw12 runner Marek Marczykowski-Górecki
[not found] ` <733860a00926d1d2d50e5914a783e5d777828442.1744403499.git-series.marmarek@invisiblethingslab.com>
2025-04-12 16:55 ` [PATCH v3 6/7] CI: remove now unused alpine-3.18-arm64-rootfs job and its container Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=107fe18c-e72c-49b4-8b48-e11817f2cf9b@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=cardoe@cardoe.com \
--cc=marmarek@invisiblethingslab.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.