Re: [PATCH] Hotplug CPU toy for i386

[Rusty Russell <rusty@rustcorp.com.au>]

On Mon, 2004-03-22 at 20:56, Zwane Mwaikambo wrote:
> On Mon, 22 Mar 2004, Rusty Russell wrote:
> 
> > @@ -1035,6 +1036,10 @@ inline void smp_local_timer_interrupt(st
> >  {
> >  	int cpu = smp_processor_id();
> >
> > +	/* FIXME: Actually remove timer interrupt in __cpu_disable() --RR */
> > +	if (cpu_is_offline(cpu))
> > +		return;
> > +
> 
> We could setup an offline cpu idt with nop type interrupt stubs, this
> could also take care of the irq_stabilizing problem later on...

The problem I have with this approach is that it shouldn't be
neccessary.  Perhaps I'm overly optimistic.

I know *nothing* about i386: I'll play with stealing the PM code's
APIC suspend/resume, which I think is the Right Way to do this.

Rusty.
-- 
Anyone who quotes me in their signature is an idiot -- Rusty Russell