From: James Bottomley <James.Bottomley@steeleye.com>
To: Grant Grundler <grundler@parisc-linux.org>
Cc: PARISC list <parisc-linux@lists.parisc-linux.org>
Subject: Re: [parisc-linux] init_idle and local_irq_save
Date: 29 Mar 2004 11:17:19 -0500 [thread overview]
Message-ID: <1080577040.1804.9.camel@mulgrave> (raw)
In-Reply-To: <20040329160357.GA31448@colo.lackof.org>
On Mon, 2004-03-29 at 11:03, Grant Grundler wrote:
> o local_irq_save()/local_irq_restore are called without an
> obvious local_irq_disable() call in between. Is this really
> needed for some other reason or is the local_irq_disable() missing?
local_irq_save() does do an irq disable. You're thinking of
local_save_flags() which only saves the flags but doesn't disable
interrupts.
> o double_rq_lock() acquires the locks with lowest address first.
> double_rq_unlock() does not release those in the inverse order.
> Is that a problem?
> I'm just nervous since I didn't see the local_irq_disable()
> in init_idle() which would guarantee both unlock's happen atomically.
No. The deadlock potential comes only from lock acquisition order, not
lock release order: nothing can block a lock release from proceeding.
James
next prev parent reply other threads:[~2004-03-29 16:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-29 16:03 [parisc-linux] init_idle and local_irq_save Grant Grundler
2004-03-29 16:17 ` James Bottomley [this message]
2004-03-29 16:31 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1080577040.1804.9.camel@mulgrave \
--to=james.bottomley@steeleye.com \
--cc=grundler@parisc-linux.org \
--cc=parisc-linux@lists.parisc-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.