From: Rusty Russell <rusty@rustcorp.com.au>
To: Arkadiusz Miskiewicz <arekm@pld-linux.org>
Cc: Andrew Morton <akpm@osdl.org>,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: modules in 2.6 kernel - question for FAQ?
Date: Thu, 15 Apr 2004 11:52:48 +1000 [thread overview]
Message-ID: <1081993968.17782.112.camel@bach> (raw)
In-Reply-To: <200404142142.41137.arekm@pld-linux.org>
On Thu, 2004-04-15 at 05:42, Arkadiusz Miskiewicz wrote:
> insmod: error inserting './Intel537.ko': -1 Invalid module format
They didn't use -fno-common. The patch which adds in the warning got
lost a while back.
Here's a new one...
Rusty.
Name: Print Warning for Common Symbols
Status: Trivial
People still build modules wrong, particularly without -fno-common.
The resulting modules don't load, but we should at least warn about it.
diff -urpN --exclude TAGS -X /home/rusty/devel/kernel/kernel-patches/current-dontdiff --minimal .17714-linux-2.6.5-bk2/kernel/module.c .17714-linux-2.6.5-bk2.updated/kernel/module.c
--- .17714-linux-2.6.5-bk2/kernel/module.c 2004-04-15 09:24:16.000000000 +1000
+++ .17714-linux-2.6.5-bk2.updated/kernel/module.c 2004-04-15 10:32:39.000000000 +1000
@@ -1003,6 +1003,8 @@ static int simplify_symbols(Elf_Shdr *se
/* We compiled with -fno-common. These are not
supposed to happen. */
DEBUGP("Common symbol: %s\n", strtab + sym[i].st_name);
+ printk("%s: please compile with -fno-common\n",
+ mod->name);
ret = -ENOEXEC;
break;
--
Anyone who quotes me in their signature is an idiot -- Rusty Russell
next parent reply other threads:[~2004-04-15 1:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200404142142.41137.arekm@pld-linux.org>
2004-04-15 1:52 ` Rusty Russell [this message]
2004-04-15 4:44 ` modules in 2.6 kernel - question for FAQ? Sam Ravnborg
2004-04-15 4:54 ` Rusty Russell
2004-04-15 13:41 ` Chris Friesen
2004-04-15 13:56 ` Arjan van de Ven
2004-04-15 14:57 ` Chris Friesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1081993968.17782.112.camel@bach \
--to=rusty@rustcorp.com.au \
--cc=akpm@osdl.org \
--cc=arekm@pld-linux.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.