From: Andreas Gruenbacher <agruen@suse.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>, lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] Return more useful error number when acls are too large
Date: Mon, 26 Apr 2004 12:27:58 +0200 [thread overview]
Message-ID: <1082973939.3295.16.camel@winden.suse.de> (raw)
Hello,
could you please add this to mainline? Getting EINVAL when an acl
becomes too large is quite confusing.
Index: linux-2.6.6-rc2/fs/ext2/acl.c
===================================================================
--- linux-2.6.6-rc2.orig/fs/ext2/acl.c 2004-04-20 23:29:46.000000000 +0200
+++ linux-2.6.6-rc2/fs/ext2/acl.c 2004-04-26 11:45:59.724792120 +0200
@@ -256,7 +256,7 @@
}
if (acl) {
if (acl->a_count > EXT2_ACL_MAX_ENTRIES)
- return -EINVAL;
+ return -ENOSPC;
value = ext2_acl_to_disk(acl, &size);
if (IS_ERR(value))
return (int)PTR_ERR(value);
Index: linux-2.6.6-rc2/fs/ext3/acl.c
===================================================================
--- linux-2.6.6-rc2.orig/fs/ext3/acl.c 2004-04-20 23:28:53.000000000 +0200
+++ linux-2.6.6-rc2/fs/ext3/acl.c 2004-04-26 11:46:05.143968280 +0200
@@ -260,7 +260,7 @@
}
if (acl) {
if (acl->a_count > EXT3_ACL_MAX_ENTRIES)
- return -EINVAL;
+ return -ENOSPC;
value = ext3_acl_to_disk(acl, &size);
if (IS_ERR(value))
return (int)PTR_ERR(value);
Thanks,
--
Andreas Gruenbacher <agruen@suse.de>
SUSE Labs, SUSE LINUX AG
next reply other threads:[~2004-04-26 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-26 10:27 Andreas Gruenbacher [this message]
2004-04-27 1:24 ` [PATCH] Return more useful error number when acls are too large Nathan Scott
2004-04-27 18:07 ` Andreas Gruenbacher
2004-04-27 18:32 ` J. Bruce Fields
2004-04-27 19:10 ` Andreas Gruenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1082973939.3295.16.camel@winden.suse.de \
--to=agruen@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.