Re: [PATCH] radeonfb(): memmove() fix -- this one works ;-)

[Benjamin Herrenschmidt <benh@kernel.crashing.org>]

On Wed, 2004-04-28 at 09:24, James Simmons wrote:
> > No, this would not be for the stable release.  But what I'm saying is 
> > that it's nice that a program cleans up after itself but we shouldn't 
> > rely on it.  Take resources like memory, file handles, sockets, etc.  
> > Most program release those resources when the shut down normally but 
> > what if they seg fault or exit unexpectedly?  The kernel cleans up after 
> > the process regardless.
> > 
> > So if a fb program restores the mode properly then we should do nothing 
> > but if it doesn't either because of a bad programming or an unexpected 
> > termination then we should reset the mode to what the user has selected 
> > for their console.
> 
> Trust me. I wish the console would cleanup itself. It would take a good 
> amount of work to redo.

Nah, it's a lot easier to restore the state you need than to
save/restore everything. It's not even always possible to save/restore
everything (think: write only registers).

I got that pretty much working lately with the new blank() argument
anyway, though some drivers need to be told about it FB_ACTIVATE_FORCE I
suppose.

Ben.




-------------------------------------------------------
This SF.Net email is sponsored by: Oracle 10g
Get certified on the hottest thing ever to hit the market... Oracle 10g. 
Take an Oracle 10g class now, and we'll give you the exam FREE. 
http://ads.osdn.com/?ad_id=3149&alloc_id=8166&op=click