Re: Oops unplugging USB stick

[James Bottomley <James.Bottomley@steeleye.com>]

On Thu, 2004-05-13 at 11:03, Oliver Neukum wrote:
> May 13 16:48:20 macbeth kernel: usb 1-1: USB disconnect, address 2
> May 13 16:48:20 macbeth kernel: sd 1:0:0:0: Illegal state transition offline->cancel
> May 13 16:48:20 macbeth kernel: Badness in scsi_device_set_state at drivers/scsi/scsi_lib.c:1640
> May 13 16:48:20 macbeth kernel: Call Trace:
> May 13 16:48:20 macbeth kernel:  [<c0304bda>] scsi_device_set_state+0xea/0x140
[...]

That's not actually an oops, it's just a warning that there's an error
in the state model....the machine proceeded normally after the messages
appeared, didn't it?  Actually, this one looks to be a residual of the
fix to a previous problem.  Does the attached make the message go away?

James

===== drivers/scsi/scsi_lib.c 1.126 vs edited =====
--- 1.126/drivers/scsi/scsi_lib.c	Wed Mar 31 16:32:26 2004
+++ edited/drivers/scsi/scsi_lib.c	Thu May 13 11:35:39 2004
@@ -1610,7 +1610,9 @@
 
 	case SDEV_CANCEL:
 		switch (oldstate) {
+		case SDEV_CREATED:
 		case SDEV_RUNNING:
+		case SDEV_OFFLINE:
 			break;
 		default:
 			goto illegal;
@@ -1619,9 +1621,7 @@
 
 	case SDEV_DEL:
 		switch (oldstate) {
-		case SDEV_CREATED:
 		case SDEV_CANCEL:
-		case SDEV_OFFLINE:
 			break;
 		default:
 			goto illegal;