From: David Howells <dhowells@redhat.com>
To: Or Gerlitz <ogerlitz@mellanox.com>
Cc: dhowells@redhat.com, netdev <netdev@vger.kernel.org>
Subject: Re: private netdev flags into UAPI?
Date: Mon, 26 Nov 2012 09:22:41 +0000 [thread overview]
Message-ID: <10845.1353921761@warthog.procyon.org.uk> (raw)
In-Reply-To: <50B1CC1B.20104@mellanox.com>
Or Gerlitz <ogerlitz@mellanox.com> wrote:
> not sure if this has been brought up before, but I realized that the private
> IFF_yyy netdevice flags which weren't exposed to user space so far have been
> moved to include/uapi/linux/if.h, isn't that wrong?
They were exposed to userspace already. On my Fedora 16 test box, I see:
[root@andromeda ~]# grep -r IFF_EBRIDGE /usr/include/linux
/usr/include/linux/if.h:#define IFF_EBRIDGE 0x2 /* Ethernet bridging device. */
which is from:
kernel-headers-3.3.6-3.fc16.x86_64
which was built before UAPI proper started going in:
[root@andromeda ~]# rpm -qfi /usr/include/linux/if.h | grep "Build Date"
Build Date : Wed 16 May 2012 23:05:59 BST
Looking at commit 607ca46e97a1b6594b29647d98a32d545c24bdff, I see:
--------------------------- include/uapi/linux/if.h ---------------------------
similarity index 100%
rename from include/linux/if.h
rename to include/uapi/linux/if.h
so my script just moved it without alteration.
David
next prev parent reply other threads:[~2012-11-26 9:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-25 7:43 private netdev flags into UAPI? Or Gerlitz
2012-11-26 9:22 ` David Howells [this message]
2012-11-26 22:29 ` Or Gerlitz
2012-11-27 2:03 ` David Howells
2012-11-27 6:51 ` Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10845.1353921761@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.