From: Dave Hansen <haveblue@us.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Andrew Morton <akpm@osdl.org>,
torvalds@osdl.org,
PPC64 External List <linuxppc64-dev@lists.linuxppc.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dynamic addition of virtual disks on PPC64 iSeries
Date: Mon, 24 May 2004 00:23:28 -0700 [thread overview]
Message-ID: <1085383408.20577.7.camel@nighthawk> (raw)
In-Reply-To: <20040524170504.29a8d001.sfr@canb.auug.org.au>
On Mon, 2004-05-24 at 00:05, Stephen Rothwell wrote:
> On Sun, 23 May 2004 23:29:20 -0700 Andrew Morton <akpm@osdl.org> wrote:
> > Or to generate a hotplug event when a disk is added? Even if there's no
> > notification to the kernel, it should be possible to generate the hotplug
> > events in response to a /proc-based trigger.
>
> I guess that would be possible. In this case I am trying to do the
> minimum change.
I think this would be a worthy change. It's the same kind of thing that
we're planning for memory hotplug on ppc64: initiate a probe in /sys
somewhere, and get a few hotplug events in short order. The only
difference is that we'll probably require a write for the probe to
trigger. You don't want a 'grep -r foo /sys' to cause probes, do you?
> + printk(VIOD_KERN_INFO "disk %d: %lu sectors (%lu MB) "
> + "CHS=%d/%d/%d sector size %d%s\n",
> + dev_no, (unsigned long)(d->size >> 9),
> + (unsigned long)(d->size >> 20),
> + (int)d->cylinders, (int)d->tracks,
> + (int)d->sectors, (int)d->bytes_per_sector,
> + d->read_only ? " (RO)" : "");
> +
Isn't it a little naughty to be spitting out so many values in a /sys
file?
-- Dave
next prev parent reply other threads:[~2004-05-24 7:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-24 6:20 [PATCH] dynamic addition of virtual disks on PPC64 iSeries Stephen Rothwell
[not found] ` <20040523232920.2fb0640a.akpm@osdl.org>
2004-05-24 7:05 ` Stephen Rothwell
2004-05-24 7:23 ` Dave Hansen [this message]
2004-05-24 7:36 ` Stephen Rothwell
2004-05-24 8:41 ` Stephen Rothwell
2004-05-24 8:49 ` Andrew Morton
2004-05-24 10:22 ` Stephen Rothwell
2004-05-24 11:50 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1085383408.20577.7.camel@nighthawk \
--to=haveblue@us.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@lists.linuxppc.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.