From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "David S. Miller" <davem@redhat.com>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix typo in pmac_zilog
Date: Sun, 30 May 2004 17:13:38 +1000 [thread overview]
Message-ID: <1085901218.10399.11.camel@gaston> (raw)
In-Reply-To: <20040529234258.42a2dc64.davem@redhat.com>
On Sun, 2004-05-30 at 16:42, David S. Miller wrote:
> On Fri, 28 May 2004 13:40:55 +1000
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> > This patch fixes a typo preventing channel B from working on the Rx
> > path of pmac zilog (never calling tty_flip_*). I think I never tested
> > channel B :)
>
> Ben, why do you do the tty_flip_buffer_push() outside of
> the port lock? Just because it's expensive and therefore
> this decreases the lock hold time, or is there some deadlock
> issue?
>
> Sounds like I should make the change to sunzilog :-)
There is a deadlock issue. I triggered once when I had a bug where the
driver was flooding the input with zero's. All serial drivers seem to be
affected. Apparently, tty_flip_* may call back into your write() routine
Ben.
next prev parent reply other threads:[~2004-05-30 7:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-28 3:40 [PATCH] Fix typo in pmac_zilog Benjamin Herrenschmidt
2004-05-30 6:42 ` David S. Miller
2004-05-30 7:13 ` Benjamin Herrenschmidt [this message]
2004-05-31 0:32 ` David S. Miller
2004-05-31 0:30 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1085901218.10399.11.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.