From: Yury Umanets <torque@ukrpost.net>
To: akpm@osdl.org
Cc: jj@sunsite.mff.cuni.cz, linux-kernel@vger.kernel.org
Subject: [PATCH] 2.6.6 invalid usage of GFP_DMA in drivers/scsi/pluto.c
Date: Tue, 08 Jun 2004 13:11:51 +0300 [thread overview]
Message-ID: <1086689511.2818.15.camel@firefly> (raw)
Hello Andrew, guys,
Found this, what seems to be an invalid usage of GFP_DMA flag. Is this
patch okay?
Thanks.
./linux-2.6.6-modified/drivers/scsi/pluto.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
Signed-off-by: Yury Umanets <torque@ukrpost.net>
--- ./linux-2.6.6/drivers/scsi/pluto.c Mon May 10 05:32:27 2004
+++ ./linux-2.6.6-modified/drivers/scsi/pluto.c Tue Jun 8 11:26:07 2004
@@ -117,7 +117,8 @@ int __init pluto_detect(Scsi_Host_Templa
#endif
return 0;
}
- fcs = (struct ctrl_inquiry *) kmalloc (sizeof (struct ctrl_inquiry) *
fcscount, GFP_DMA);
+ fcs = (struct ctrl_inquiry *) kmalloc (sizeof (struct ctrl_inquiry) *
fcscount,
+ GFP_KERNEL | GFP_DMA);
if (!fcs) {
printk ("PLUTO: Not enough memory to probe\n");
return 0;
--
umka
next reply other threads:[~2004-06-08 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-08 10:11 Yury Umanets [this message]
2004-06-08 10:17 ` [PATCH] 2.6.6 invalid usage of GFP_DMA in drivers/scsi/pluto.c Andrew Morton
2004-06-08 11:07 ` Yury Umanets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1086689511.2818.15.camel@firefly \
--to=torque@ukrpost.net \
--cc=akpm@osdl.org \
--cc=jj@sunsite.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.