From: Hollis Blanchard <hollisb@us.ibm.com>
To: Leigh Brown <leigh@solinno.co.uk>
Cc: linuxppc-dev@lists.linuxppc.org
Subject: Re: [PATCH][RFC] have_residual_data()
Date: Wed, 09 Jun 2004 14:39:54 -0500 [thread overview]
Message-ID: <1086809994.3227.83.camel@localhost> (raw)
In-Reply-To: <1290.81.137.83.225.1086682323.squirrel@www.solinno.co.uk>
On Tue, 2004-06-08 at 03:12, Leigh Brown wrote:
> I just read Gustavo's email, and co-incidently have finally began looking
> again at my patches over the last couple of days to see about making
> them good enough to submit. To this end, please find attached a patch
> to create a new inline function have_residual_data(), which looks like
> this:
>
> static inline int have_residual_data(void) {
> #if defined(CONFIG_PREP_RESIDUAL)
> return res && res->ResidualLength;
> #else /* !defined(CONFIG_PREP_RESIDUAL) */
> return 0;
> #endif /* defined(CONFIG_PREP_RESIDUAL) */
> }
Sounds like a great idea. :) Without having time to read the whole
patch, I think preferred style is:
#if defined(CONFIG_PREP_RESIDUAL)
static inline int have_residual_data(void) {
return res && res->ResidualLength;
}
#else /* !defined(CONFIG_PREP_RESIDUAL) */
static inline int have_residual_data(void) {
return 0;
}
#endif /* defined(CONFIG_PREP_RESIDUAL) */
--
Hollis Blanchard
IBM Linux Technology Center
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
next prev parent reply other threads:[~2004-06-09 19:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-08 8:12 [PATCH][RFC] have_residual_data() Leigh Brown
2004-06-09 19:39 ` Hollis Blanchard [this message]
2004-06-10 7:55 ` Leigh Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1086809994.3227.83.camel@localhost \
--to=hollisb@us.ibm.com \
--cc=leigh@solinno.co.uk \
--cc=linuxppc-dev@lists.linuxppc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.