From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: MARK target extension Date: Sun, 13 Jun 2004 22:23:08 +0200 Sender: netfilter-devel-admin@lists.netfilter.org Message-ID: <1087158188.11287.33.camel@ws> References: Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Grzegorz Nosek , netfilter-devel@lists.netfilter.org Return-path: To: Henrik Nordstrom In-Reply-To: Errors-To: netfilter-devel-admin@lists.netfilter.org List-Help: List-Post: List-Subscribe: , List-Unsubscribe: , List-Archive: List-Id: netfilter-devel.vger.kernel.org On Wed, 2004-06-09 at 15:43, Henrik Nordstrom wrote: > On Wed, 9 Jun 2004, Patrick McHardy wrote: > > I do agree that it is nice to have the functionality of xor. > > May I propose that to solve this a userspace option is added "--xor-mark > value", and that mask 0 is probited in --set-mark if this representation > is used. Seems like a good way. I'm also going to add --and-mark and --or-mark as alternative representations. I'll post the patch before applying it to see if everyone is happy. > > One of my concerns was that MARK and CONNMARK should look and behave > > the same way. We should either change CONNMARK to also use xor, or > > change your patch to using or. Henrik, what do you think ? > > I have no problem adjusting CONNMARK if a acceptable notation is found. It > has not yet been submitted to the kernel even if this has been favorly > discussed many times already. Yes, I know. I hope it will go in soon .. Regards Patrick