From: Len Brown <len.brown@intel.com>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: Hans-Frieder Vogt <hfvogt@arcor.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.4.27-rc1 i386 and x86_64 ACPI mpparse timer bug
Date: 21 Jun 2004 16:00:51 -0400 [thread overview]
Message-ID: <1087848051.4319.202.camel@dhcppc4> (raw)
In-Reply-To: <200406202355.i5KNtPdp021261@harpo.it.uu.se>
Thanks Mikael, Hans, you got it right.
-Len
On Sun, 2004-06-20 at 19:55, Mikael Pettersson wrote:
> 2.4.27-rc1 reintroduced the double-speed timer ACPI bug.
> Both x86-64 and i386 are affected.
>
> The patch below fixes it on my box. It's a backport of a
> patch Hans-Frieder Vogt made for 2.6.7-bk2, extended to
> also handle i386.
>
> /Mikael Pettersson
>
> diff -ruN linux-2.4.27-rc1/arch/i386/kernel/mpparse.c linux-2.4.27-rc1.mpparse-fix/arch/i386/kernel/mpparse.c
> --- linux-2.4.27-rc1/arch/i386/kernel/mpparse.c 2004-06-21 00:39:30.000000000 +0200
> +++ linux-2.4.27-rc1.mpparse-fix/arch/i386/kernel/mpparse.c 2004-06-21 00:50:01.000000000 +0200
> @@ -1211,7 +1211,7 @@
>
> for (idx = 0; idx < mp_irq_entries; idx++)
> if (mp_irqs[idx].mpc_srcbus == MP_ISA_BUS &&
> - (mp_irqs[idx].mpc_dstapic == ioapic) &&
> + (mp_irqs[idx].mpc_dstapic == mp_ioapics[ioapic].mpc_apicid) &&
> (mp_irqs[idx].mpc_srcbusirq == i ||
> mp_irqs[idx].mpc_dstirq == i))
> break;
> diff -ruN linux-2.4.27-rc1/arch/x86_64/kernel/mpparse.c linux-2.4.27-rc1.mpparse-fix/arch/x86_64/kernel/mpparse.c
> --- linux-2.4.27-rc1/arch/x86_64/kernel/mpparse.c 2004-06-21 00:39:30.000000000 +0200
> +++ linux-2.4.27-rc1.mpparse-fix/arch/x86_64/kernel/mpparse.c 2004-06-21 00:50:01.000000000 +0200
> @@ -866,7 +866,7 @@
>
> for (idx = 0; idx < mp_irq_entries; idx++)
> if (mp_irqs[idx].mpc_srcbus == MP_ISA_BUS &&
> - (mp_irqs[idx].mpc_dstapic == ioapic) &&
> + (mp_irqs[idx].mpc_dstapic == intsrc.mpc_dstapic) &&
> (mp_irqs[idx].mpc_srcbusirq == i ||
> mp_irqs[idx].mpc_dstirq == i))
> break;
prev parent reply other threads:[~2004-06-21 20:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-20 23:55 [PATCH] 2.4.27-rc1 i386 and x86_64 ACPI mpparse timer bug Mikael Pettersson
2004-06-21 20:00 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1087848051.4319.202.camel@dhcppc4 \
--to=len.brown@intel.com \
--cc=hfvogt@arcor.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@csd.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.