From: Marcel Holtmann <marcel@holtmann.org>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Marcel Holtmann <marcel@holtman.org>,
Max Krasnyansky <maxk@qualcomm.com>,
BlueZ Mailing List <bluez-devel@lists.sourceforge.net>
Subject: Re: [Bluez-devel] [PATCH] change inquiry_cache to hci_inquiry_cache to avoid possible name conflicts
Date: Wed, 23 Jun 2004 11:11:54 +0200 [thread overview]
Message-ID: <1087981913.4209.70.camel@pegasus> (raw)
In-Reply-To: <20040622144148.13ef5b10@dell_ss3.pdx.osdl.net>
Hi Stephen,
> This patch changes the inquiry_XXX function to be either local to hci_core.c
> or change name from inquiry_cache_lookup to hci_inquiry_cache_lookup to try and
> reduce the potential for namespace conflicts. There could be USB or SCSI or other
> code that uses an inquiry_cache.
you forgot to change it in hci_conn.c:
CC [M] net/bluetooth/hci_conn.o
net/bluetooth/hci_conn.c: In function `hci_acl_connect':
net/bluetooth/hci_conn.c:72: warning: implicit declaration of function `inquiry_cache_lookup'
net/bluetooth/hci_conn.c:72: warning: assignment makes pointer from integer without a cast
Please fix this and resend the patch.
Regards
Marcel
-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 -
digital self defense, top technical experts, no vendor pitches,
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel
prev parent reply other threads:[~2004-06-23 9:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-22 21:41 [Bluez-devel] [PATCH] change inquiry_cache to hci_inquiry_cache to avoid possible name conflicts Stephen Hemminger
2004-06-23 9:11 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1087981913.4209.70.camel@pegasus \
--to=marcel@holtmann.org \
--cc=bluez-devel@lists.sourceforge.net \
--cc=marcel@holtman.org \
--cc=maxk@qualcomm.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.