From: FabF <fabian.frederick@skynet.be>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.7-mm1] MBR centralization
Date: Thu, 24 Jun 2004 00:04:35 +0200 [thread overview]
Message-ID: <1088028275.2213.45.camel@localhost.localdomain> (raw)
In-Reply-To: <20040623140650.46f184bd.akpm@osdl.org>
On Wed, 2004-06-23 at 23:06, Andrew Morton wrote:
> FabF <fabian.frederick@skynet.be> wrote:
> >
> > +/*Master boot record magic numbers*/
> > +#define MSDOS_MBR_SIGNATURE 0xaa55
> > +#define MSDOS_MBR(p) le16_to_cpu((u16)*p) == MSDOS_MBR_SIGNATURE
>
> I'd make this
>
> /*
> * Check for MSDOS Master Boot Record signature
> */
> static inline int msdos_mbr(u16 v)
> {
> return le16_to_cpu(v) == 0xaa55;
> }
That means I would have to cast from all msdos_partition calls
e.g. msdos_mbr((u16)*(data+510)) .Is this the right way ?
Regards,
FabF
next prev parent reply other threads:[~2004-06-23 21:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-23 21:15 [PATCH 2.6.7-mm1] MBR centralization FabF
2004-06-23 21:06 ` Andrew Morton
2004-06-23 22:04 ` FabF [this message]
2004-06-23 21:36 ` Andries Brouwer
2004-06-24 6:07 ` FabF
2004-06-24 12:57 ` Andries Brouwer
[not found] ` <Pine.LNX.4.60.0406240809280.29245@hermes-1.csi.cam.ac.uk>
[not found] ` <Pine.LNX.4.60.0406240829550.29245@hermes-1.csi.cam.ac.uk>
2004-06-24 13:06 ` Andries Brouwer
[not found] ` <1088152223.16286.9.camel@imp.csi.cam.ac.uk>
2004-06-25 9:39 ` Andries Brouwer
2004-06-24 15:10 ` FabF
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1088028275.2213.45.camel@localhost.localdomain \
--to=fabian.frederick@skynet.be \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.