All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Kumlien <pomac@vapor.com>
To: linux-kernel@vger.kernel.org
Cc: Donald Becker <becker@scyld.com>, "David S. Miller" <davem@redhat.com>
Subject: [PATCH/RFC] b44 and sundance watchdog changes.
Date: Fri, 25 Jun 2004 17:55:30 +0200	[thread overview]
Message-ID: <1088178930.23713.27.camel@big> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 1043 bytes --]

Hi, 

I experimented some with the watchdog timers in these drivers because i
had some problems with em.

sundance.c:
I first raised this to 8 (and had no problems with it) but since too
many watchdog 'resets' breaks the hardware to the point where you have
to actually shutdown the machine for a while, i thought, better safe
than sorry.

b44.c:
My first try was to raise the timer to 10, but i actually got a failure,
so i increased it again by a 5s increment.

This was tested while transfering ~20 gigs of data via nfs.
The only problem that i experienced during this time is 2x:
b44: eth0: Link is down.
b44: eth0: Link is up at 100 Mbps, full duplex.
b44: eth0: Flow control is on for TX and on for RX.

There was no messages at all from the sundance driver, it worked
perfectly.

Comments? suggestions?

PS. Sorry, couldn't find anyone listed in maintainers, so module authors
was added to CC =P

CC me since i'm not subscribed.
DS.

-- 
Ian Kumlien <pomac () vapor ! com> -- http://pomac.netswarm.net

[-- Attachment #1.2: b44.diff --]
[-- Type: text/x-patch, Size: 457 bytes --]

--- linux/drivers/net/b44.c.old	2004-06-25 05:14:23.000000000 +0200
+++ linux/drivers/net/b44.c	2004-06-25 15:38:22.000000000 +0200
@@ -43,7 +43,7 @@
 /* length of time before we decide the hardware is borked,
  * and dev->tx_timeout() should be called to fix the problem
  */
-#define B44_TX_TIMEOUT			(5 * HZ)
+#define B44_TX_TIMEOUT			(15 * HZ)
 
 /* hardware minimum and maximum for a single frame's data payload */
 #define B44_MIN_MTU			60

[-- Attachment #1.3: sundance.diff --]
[-- Type: text/x-patch, Size: 445 bytes --]

--- linux/drivers/net/sundance.c.old	2004-06-25 05:14:13.000000000 +0200
+++ linux/drivers/net/sundance.c	2004-06-25 05:14:49.000000000 +0200
@@ -145,7 +145,7 @@
 
 /* Operational parameters that usually are not changed. */
 /* Time in jiffies before concluding the transmitter is hung. */
-#define TX_TIMEOUT  (4*HZ)
+#define TX_TIMEOUT  (10*HZ)
 #define PKT_BUF_SZ		1536	/* Size of each temporary Rx buffer.*/
 
 #ifndef __KERNEL__

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

                 reply	other threads:[~2004-06-25 15:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1088178930.23713.27.camel@big \
    --to=pomac@vapor.com \
    --cc=becker@scyld.com \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.