From mboxrd@z Thu Jan 1 00:00:00 1970 From: christophe.varoqui@free.fr Date: Mon, 05 Jul 2004 12:11:31 +0000 Subject: Re: Patch to multipath-tools 0.2.4 Message-Id: <1089029491.40e945734f76f@imp2-q.free.fr> List-Id: References: <40E92177.7000800@suse.de> In-Reply-To: <40E92177.7000800@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-hotplug@vger.kernel.org Thanks, merged in multipath-tools-0.2.5 it works here on StorageWorks : xa-s03:~/multipath/multipath-tools-0.2.5/multipath# ./multipath -v /dev/sda: ID descriptor at 4: /dev/sda: Association: 0 /dev/sda: Codeset: 1 /dev/sda: ID type: NAA IEEE Registered Extended /dev/sda: binary 600508b4000156d700012000000b0000 (len 20) /dev/sdb: ID descriptor at 4: /dev/sdb: Association: 0 /dev/sdb: Codeset: 1 /dev/sdb: ID type: NAA IEEE Registered Extended /dev/sdb: binary 600508b4000156d700012000000b0000 (len 20) # all paths : 600508b4000156d700012000000b0000 (3 0 0 1) /dev/sda [HSV110 (C)COMPAQ] 600508b4000156d700012000000b0000 (3 0 1 1) /dev/sdb [HSV110 (C)COMPAQ] # all multipaths : 600508b4000156d700012000000b0000 \_(3 0 0 1) /dev/sda [HSV110 (C)COMPAQ] \_(3 0 1 1) /dev/sdb [HSV110 (C)COMPAQ] # device maps : U:600508b4000156d700012000000b0000:0 62914560 multipath 2 round-robin 1 0 /dev/sda round-robin 1 0 /dev/sdb If you want the IBM ESS strings in the default config file and core default= s, please send the corresponding patch. regards, cvaroqui Selon Hannes Reinecke : > Hi Christophe, >=20 > I've made a patch to multipath-tools 0.2.4 to correctly decipher SCSI=20 > EVPD page 0x83. The current code is totally ignorant of the fact that=20 > EVPD page 0x83 can return more than one identifier, some of which are=20 > either bogus (i.e. containing an empty string) or should be preferred to = > the other identifiers. >=20 > The attached patch > - correctly deciphers EVPD page 0x83 > - Tries to select the 'best' candidate if several IDs are returned: > - ID should not be empty (i.e. either only spaces or Nulls) > - Order of preference: > - NAA (hightest subtype is preferrred) > - EUI-64 > - T-10 > - Vendor specific > - Map spaces to underscores if the serial number is ASCII; this is =09 > mainly to generate valid mapping names. >=20 > Would be great if this patch could be included, as without this the=20 > multipath tools do not work correctly with the IBM ESS. >=20 > Most of the decoding logic is in fact stolen from scsi_id (thanks=20 > Patrick), so we should probably add a copyright statement somewhere. >=20 > We should actually be using the scsi_id package directly as this would=20 > give us identical mappings for udev and multipath tools. But as this=20 > would mean a major restructuring of the program itself I took the cheap=20 > way out. Patrick, can you think of a clever way of integrating both? >=20 > Cheers, >=20 > Hannes > --=20 > Dr. Hannes Reinecke hare@suse.de > SuSE Linux AG S390 & zSeries > Maxfeldstra=DFe 5 +49 911 74053 688 > 90409 N=FCrnberg http://www.suse.de >=20 --=20 ------------------------------------------------------- This SF.Net email sponsored by Black Hat Briefings & Training. Attend Black Hat Briefings & Training, Las Vegas July 24-29 -=20 digital self defense, top technical experts, no vendor pitches,=20 unmatched networking opportunities. Visit www.blackhat.com _______________________________________________ Linux-hotplug-devel mailing list http://linux-hotplug.sourceforge.net Linux-hotplug-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel