From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Eger <eger@havoc.gtf.org>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
Linux Fbdev development list
<linux-fbdev-devel@lists.sourceforge.net>
Subject: Re: Re: [PATCH] radeonfb: remove reg_lock nonsense
Date: Wed, 07 Jul 2004 10:35:11 -0500 [thread overview]
Message-ID: <1089214511.2026.25.camel@gaston> (raw)
In-Reply-To: <20040707072441.GA13160@havoc.gtf.org>
> radeonfb can be re-entered.
>
> Hmmm :-/
>
> In that case, I have a patch which implements both of Linus's suggestions,
> making OUTPLL()/INPLL() inlines and making the caller responsible for
> taking the register lock when calling OUTPLL()/INPLL().
>
> On the upside, the number of lockings goes down from 159 to 24.
> On the downside, that means about 70 more lines of code via:
> from 48 spin lock & unlock lines and 17 'flags' decls
>
> I'll leave it up to your discretion whether to apply.
It's probably better to move to such locking, indeed. Just make sure
you don't keep the lock on the wait_for_* loops though (haven't looked
at the code in detail yet).
Ben.
-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 -
digital self defense, top technical experts, no vendor pitches,
unmatched networking opportunities. Visit www.blackhat.com
prev parent reply other threads:[~2004-07-07 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200407051043.i65AhCG13509@mail.osdl.org>
[not found] ` <Pine.LNX.4.58.0407051028250.1764@ppc970.osdl.org>
2004-07-06 8:10 ` [PATCH] radeonfb: remove reg_lock nonsense David Eger
2004-07-06 12:08 ` Benjamin Herrenschmidt
2004-07-07 7:24 ` David Eger
2004-07-07 15:35 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1089214511.2026.25.camel@gaston \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=eger@havoc.gtf.org \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.