From: David Woodhouse <dwmw2@infradead.org>
To: "Øyvind Harboe" <oyvind.harboe@zylin.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: Prune obsolete raw_node_ref's from RAM
Date: Wed, 14 Jul 2004 00:14:14 +0100 [thread overview]
Message-ID: <1089760454.8822.23.camel@imladris.demon.co.uk> (raw)
In-Reply-To: <1089728296.6288.19.camel@famine>
On Tue, 2004-07-13 at 16:18 +0200, Øyvind Harboe wrote:
> - Is the code correct?
It looks OK at first glance but I can't actually tell. List mangling
code is hard enough to read when it's in the style I understand :)
I've rewritten it and just posted that version.
> - What performance impact does it have?
It'll go walking the lists every time a node is obsoleted. My guess is
it'll make the performance suck _hard_. But it will get you your memory
back. I suspect it should be a configuration option -- or maybe we could
stick the list-walking code into a separate function and call it
periodically to do the cleanup, rather than doing it every time.
Could do with seeing some profiling info.
--
dwmw2
next prev parent reply other threads:[~2004-07-13 23:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-13 14:18 Prune obsolete raw_node_ref's from RAM Øyvind Harboe
2004-07-13 23:14 ` David Woodhouse [this message]
2004-07-14 6:26 ` Øyvind Harboe
2004-07-14 6:41 ` David Woodhouse
2004-07-14 6:51 ` Øyvind Harboe
2004-07-14 7:08 ` David Woodhouse
2004-07-14 7:27 ` Øyvind Harboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1089760454.8822.23.camel@imladris.demon.co.uk \
--to=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=oyvind.harboe@zylin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.