All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Stekloff <dsteklof@us.ibm.com>
To: linux-hotplug@vger.kernel.org
Subject: Re: getpagesize / libsysfs broken with 0.148
Date: Thu, 15 Jul 2004 14:53:44 +0000	[thread overview]
Message-ID: <1089903223.1556.14.camel@localhost.localdomain> (raw)
In-Reply-To: <40F6457F.8050200@suse.de>

On Thu, 2004-07-15 at 01:51, Hannes Reinecke wrote:
> Hi all,
> 
> the implementation of getpagesize() is broken in klibc.
> 
> klibc uses sysinfo.mem_unit, which linux interpretes as the memory unit 
> all other memory values returned are to be multiplied with.
> So it's perfectly ok for the linux sysinfo() to return a mem_unit of 
> '1', which is does if the memory available for this machine fits into 
> the counter.
> For the unbelievers, have a look in kernel/timer.c:sys_sysinfo().
> 
> As a quick hack I've added a check for mem_unit=1 and reset the 
> page_size to 4096 on those cases.
> 
> Naturally, this is not the right fix. The right fix would be to get the 
> values from the kernel headers and/or some magic juju for those machines 
> with variable pagesize.
> 
> It probably would not have been noticed, but as libsysfs insists on 
> doing all reads from sysfs attributes with a length of pagesize, the 
> failures were ... interesting.


Libsysfs reads with length of pagesize because that was a sysfs
limitation. Has sysfs changed? 

There use to be an ifdef klibc around the getpagesize() call but that
seems to have been removed at some point. 

Thanks, 

Dan




> So in short, udev does _not_ work with klibc until that (or an 
> equivalent) patch is applied.
> 
> Cheers,
> 
> Hannes



-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_idG21&alloc_id\x10040&op=click
_______________________________________________
Linux-hotplug-devel mailing list  http://linux-hotplug.sourceforge.net
Linux-hotplug-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-hotplug-devel

  parent reply	other threads:[~2004-07-15 14:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-15  8:51 getpagesize / libsysfs broken with 0.148 Hannes Reinecke
2004-07-15  9:10 ` Harald Hoyer
2004-07-15  9:24 ` Hannes Reinecke
2004-07-15 14:53 ` Daniel Stekloff [this message]
2004-07-15 15:57 ` [klibc] " H. Peter Anvin
2004-07-15 17:44 ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1089903223.1556.14.camel@localhost.localdomain \
    --to=dsteklof@us.ibm.com \
    --cc=linux-hotplug@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.